Bug 210039 - emulators/wine-devel: enable Xinerama
Summary: emulators/wine-devel: enable Xinerama
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gerald Pfeifer
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-06-04 22:13 UTC by Henry Hu
Modified: 2016-08-23 10:11 UTC (History)
1 user (show)

See Also:
gerald: maintainer-feedback+

Attachments
patch to enable xinerama (1.12 KB, patch)
2016-06-04 22:13 UTC, Henry Hu 		vlad-fbsd: maintainer-approval? (gerald)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2016-06-04 22:13:15 UTC 
Created attachment 171031 [details]
patch to enable xinerama

Currently, Xinerama is explicitly disabled. As a result, with 2 monitors, WINE returns a huge virtual screen in GetMonitorInfo, instead of 2 separate monitors. This causes some programs to incorrectly fullscreen as a wide window covering 2 monitors, which is hard to use.

As an example, check pipelight. Currently, when asked to become fullscreen, the flash player would create a large wide window, and show the video content in the middle, half on each monitor. This makes it really inconvenient to view the video.

This patch enables Xinerama. It removes the --without-xinerama option and adds the dependencies. i386-wine-* would automatically pick up the 32bit libXinerama.so.*, so it's not necessary to modify other parts.

I've tested it with pipelight and i386-wine-staging and it makes the flash player correctly show a fullscreen window.
Comment 1 Gerald Pfeifer freebsd_committer freebsd_triage 2016-06-19 13:17:08 UTC 
I'm working on this, thanks for the report and even including a patch,
Henry!

The only change I see is alphabetical sorting of options (which I'll
take care of).
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-06-19 13:35:05 UTC 
A commit references this bug:

Author: gerald
Date: Sun Jun 19 13:34:52 UTC 2016
New revision: 417122
URL: https://svnweb.freebsd.org/changeset/ports/417122

Log:
  Require/build with Xinerama support (which has been explicitly disabled
  before to ensure reproducible builds).  Without this, some programs would
  incorrectly show full screen as a wide window covering 2 monitors.

  PR:		210039
  Submitted by:	Henry Hu <henry.hu.sh@gmail.com>

Changes:
  head/emulators/wine-devel/Makefile
Comment 3 Gerald Pfeifer freebsd_committer freebsd_triage 2016-06-19 17:36:10 UTC 
Let me know what your take is on a similar update to the 
emulators/wine port.

Currently I am leaning making this in a bit.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-08-23 10:11:49 UTC 
A commit references this bug:

Author: gerald
Date: Tue Aug 23 10:11:17 UTC 2016
New revision: 420654
URL: https://svnweb.freebsd.org/changeset/ports/420654

Log:
  Backport from emulators/wine-devel:

  Require/build with Xinerama support (which has been explicitly disabled
  before to ensure reproducible builds).  Without this, some programs would
  incorrectly show full screen as a wide window covering 2 monitors.

  PR:		210039
  Submitted by:	Henry Hu <henry.hu.sh@gmail.com>

Changes:
  head/emulators/wine/Makefile