Bug 210054 - editors/neovim: UNBREAK and fix build
Summary: editors/neovim: UNBREAK and fix build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Matthew Seaman
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-06-05 14:29 UTC by Oleh Hushchenkov
Modified: 2016-06-09 19:17 UTC (History)
2 users (show)

See Also:

Attachments
Fix be64toh() detection on BSDs (3.52 KB, patch)
2016-06-05 14:29 UTC, Oleh Hushchenkov 		no flags Details | Diff
Fix be64toh() detection on BSDs (3.55 KB, patch)
2016-06-05 14:41 UTC, Oleh Hushchenkov 		vlad-fbsd: maintainer-approval+
Details | Diff
Fix be64toh() detection on BSDs from upstream (6.06 KB, patch)
2016-06-09 15:48 UTC, Oleh Hushchenkov 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleh Hushchenkov 2016-06-05 14:29:49 UTC 
Created attachment 171056 [details]
Fix be64toh() detection on BSDs

Fix be64toh() detection on BSDs by jszakmeister at GitHub.

https://github.com/neovim/neovim/issues/4750
Comment 1 Oleh Hushchenkov 2016-06-05 14:41:10 UTC 
Created attachment 171058 [details]
Fix be64toh() detection on BSDs

Additional fix portlint error. Now passes "portlint" and "port test" without errors.
Comment 2 VK 2016-06-08 23:17:56 UTC 
Comment on attachment 171058 [details]
Fix be64toh() detection on BSDs

The port has no maintainer, implicit approval.
Comment 3 Oleh Hushchenkov 2016-06-09 11:47:00 UTC 
Can anyone commit this?
Comment 4 Matthew Seaman freebsd_committer freebsd_triage 2016-06-09 13:59:55 UTC 
Hmm... Looks like a number of patchfile changes equivalent to what's in your patch were just committed in r416603.  Can you update your patch with the be64toh() fixes against the latest ports tree please?
Comment 5 Oleh Hushchenkov 2016-06-09 15:48:09 UTC 
Created attachment 171235 [details]
Fix be64toh() detection on BSDs from upstream
Comment 6 Oleh Hushchenkov 2016-06-09 15:52:25 UTC 
(In reply to Matthew Seaman from comment #4)

Added updated patch. But already committed patch mostly equivalent to this fix taken from upstream.
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-06-09 19:01:44 UTC 
A commit references this bug:

Author: matthew
Date: Thu Jun  9 19:01:28 UTC 2016
New revision: 416620
URL: https://svnweb.freebsd.org/changeset/ports/416620

Log:
  Fix be64toh() detection on BSDs from upstream

  Use patch names as generated by 'make makepatch'

  PR:		210054
  Submitted by:	gor@clogic.com.ua

Changes:
  head/editors/neovim/files/patch-config_CMakeLists.txt
  head/editors/neovim/files/patch-config__CMakeLists.txt
  head/editors/neovim/files/patch-config__config.h.in
  head/editors/neovim/files/patch-src__nvim__shada.c
  head/editors/neovim/files/patch-src_nvim_shada.c
Comment 8 Matthew Seaman freebsd_committer freebsd_triage 2016-06-09 19:03:09 UTC 
Committed, thanks!
Comment 9 Oleh Hushchenkov 2016-06-09 19:17:47 UTC 
Thank you!