Bug 210088 - multimedia/zoneminder: Unbreak build for systems with v4l1
Summary: multimedia/zoneminder: Unbreak build for systems with v4l1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-06-07 07:38 UTC by Ivan
Modified: 2016-06-09 00:15 UTC (History)
1 user (show)

See Also:

Attachments
patch (318 bytes, patch)
2016-06-07 07:38 UTC, Ivan 		bsd: maintainer-approval+
Details | Diff
patch2 (660 bytes, patch)
2016-06-07 09:57 UTC, Ivan 		bsd: maintainer-approval+
Details | Diff
patch3 (551 bytes, patch)
2016-06-07 09:59 UTC, Ivan 		bsd: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan 2016-06-07 07:38:03 UTC 
Created attachment 171123 [details]
patch

Systems lack video4linux2, but with video4linux1 fail to build ZM due to v4l2 specific macro.
FreeBSD build factory is upset too: http://portsmon.freebsd.org/portoverview.py?category=multimedia&portname=zoneminder

No revision bump required.
Comment 1 VK 2016-06-07 09:30:18 UTC 
Ivan, thanks for the patch. Can you confirm this passes build tests?

It would also be very helpful if you could submit a patch against the svn tree (resulting in a patch to add a patch) as that will make it easier to test and apply this fix.

Cleaning up summary in favor of patch flagged maintainer-approval. Also removing maintainer-feedback+ for correctness as it was never requested. ;)
Comment 2 Ivan 2016-06-07 09:57:59 UTC 
Created attachment 171127 [details]
patch2

I hope this one is proper.
Shouldn't break anything more. :] and it fixes build on affected test system.
Comment 3 Ivan 2016-06-07 09:59:36 UTC 
Created attachment 171128 [details]
patch3
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-06-09 00:14:46 UTC 
A commit references this bug:

Author: pi
Date: Thu Jun  9 00:14:07 UTC 2016
New revision: 416573
URL: https://svnweb.freebsd.org/changeset/ports/416573

Log:
  multimedia/zoneminder: Unbreak build for systems with v4l1

  Systems lacking video4linux2, but with video4linux1 fail to build
  ZM due to v4l2 specific macro.

  PR:		210088
  Submitted by:	Ivan <bsd@abinet.ru> (maintainer)

Changes:
  head/multimedia/zoneminder/files/patch-src_zm__local__camera.h
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2016-06-09 00:15:48 UTC 
Committed,thanks!