Bug 210177 - sysutils/bareos-server: Added option to build LTO crypto module
Summary: sysutils/bareos-server: Added option to build LTO crypto module
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords: easy, patch, patch-ready
Depends on: 212282
Blocks:
  Show dependency treegraph
 
Reported: 2016-06-09 19:57 UTC by Douglas K. Rand
Modified: 2016-11-21 21:00 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (acm)


Attachments
Patch to enable scsicrypto plugin (3.21 KB, patch)
2016-06-09 19:57 UTC, Douglas K. Rand
no flags Details | Diff
Patch to enable scsicrypto plugin (server & client) (3.90 KB, patch)
2016-06-10 20:53 UTC, Douglas K. Rand
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas K. Rand 2016-06-09 19:57:07 UTC
Created attachment 171244 [details]
Patch to enable scsicrypto plugin

Bareos comes with a scsicrypto.so plugin that allows Bareos to use AME (application managed encryption) with LTO tape drives. The plugin isn't built by default, so I added an option for it.

In doing so, I found that one of the patches (patch-src-plugins-stored-Makefile.in) had only addressed the first reference to libbareos.  I removed the patch and instead put the change (s|\.\./\.\./lib/libbareos|$$(LOCALBASE)/lib/libbareos|g) into a REINPLACE_CMD in the existing post-patch target. Seemed cleaner. 

Attached is an svn diff.

Thanks.
Comment 1 Douglas K. Rand 2016-06-10 20:53:40 UTC
Created attachment 171279 [details]
Patch to enable scsicrypto plugin (server & client)

Sorry, I didn't test that patch throughly enough. It works fine for the server, but the client needs the same configure string. I didn't know of an easy way to have the OPTIONS knobs common between bareos-client and bareos-server, so I simply duplicated them.

This patch adds the SCSICRYPTO config knob to both bareos-server and bareos-client.

Sorry for the extra noise.
Comment 2 O. Hartmann 2016-09-01 05:34:16 UTC
When does this useful patch see the light? On my site, it seems to append and compile clean, but to confess I haven't have time to test it with our oldish LTO4 tape libraries.

Regards,

oh