Created attachment 171251 [details] full patch against head This brings flock to the current state based on fetching the original util-linux sources and configuring them accordingly, adding a NLS knob as suggested by portlint. Since the port hasn't been tended to by the maintainer since 2011 also request maintainership.
Created attachment 171252 [details] portlint -AC output
Created attachment 171253 [details] poudriere build log
Created attachment 171254 [details] revised patch against head ${INSTALL} / ${STRIP_CMD} changed back to ${INSTALL_PROGRAM}
I don't mind.
Maintainer feedback given, flagging.
Comment on attachment 171254 [details] revised patch against head Andrey, just this tiny detail of approving the patch, to have the PR appear in the "Maintainer approved" saved search, please. :)
Comment on attachment 171254 [details] revised patch against head Done.
Created attachment 172163 [details] additional fix for unsetting NLS
On what versions did you test ? It fails to build on 12a, 11a ? It builds on 10i, 93a. See http://people.freebsd.org/~pi/logs/sysutils__flock-cur-1469443282.txt http://people.freebsd.org/~pi/logs/sysutils__flock-11a-1469443282.txt
Yup, 10. I'll patch this up. Didn't know that required removal on 11 and up. https://lists.freebsd.org/pipermail/freebsd-current/2015-January/053963.html Thanks, Franco
Created attachment 173111 [details] revised patch for FreeBSD 11+ Hi Kurt, The ifdef guard in util-linux was fixed and DIOCGMEDIASIZE is already in there so no further porting required. Cheers, Franco
testing@work
A commit references this bug: Author: pi Date: Sat Jul 30 09:40:45 UTC 2016 New revision: 419304 URL: https://svnweb.freebsd.org/changeset/ports/419304 Log: sysutils/flock: 2.19 -> 2.28 - This brings flock to the current state based on fetching the original util-linux sources and configuring them accordingly - adding a NLS knob as suggested by portlint. - For background on DIOCGDINFO see https://lists.freebsd.org/pipermail/freebsd-current/2015-January/053963.html - Submitter becomes maintainer PR: 210185 Changes: http://git.kernel.org/?p=utils/util-linux/util-linux.git/ Submitted by: Franco Fichtner <franco@opnsense.org> Approved by: zont (maintainer) Changes: head/sysutils/flock/Makefile head/sysutils/flock/distinfo head/sysutils/flock/files/ head/sysutils/flock/files/patch-include_pathnames.h head/sysutils/flock/files/patch-lib_blkdev.c
Committed, thanks!
Highly appreciated, thank you! :)