Bug 210294 - www/nginx www/nginx-devel: Add GeoIP2 (ngx_http_geoip2_module) support
Summary: www/nginx www/nginx-devel: Add GeoIP2 (ngx_http_geoip2_module) support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sergey A. Osokin
URL:
Keywords: feature, patch
Depends on:
Blocks:
 
Reported: 2016-06-15 05:15 UTC by FiLiS
Modified: 2016-11-10 14:23 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (osa)

Attachments
patch to add ngx_http_geoip2_module (1.91 KB, patch)
2016-06-18 23:22 UTC, FiLiS 		no flags Details | Diff
new patch w/o newline (1.82 KB, patch)
2016-06-20 08:19 UTC, FiLiS 		koobs: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description FiLiS 2016-06-15 05:15:36 UTC 
are there any plans to add GeoIP2 (includes IPv6 addresses) support, for example from https://github.com/leev/ngx_http_geoip2_module?
Comment 1 Sergey A. Osokin freebsd_committer freebsd_triage 2016-06-17 22:46:34 UTC 
Hi Philip,

thanks for report, could you please provide a patch for the feature.
Comment 2 FiLiS 2016-06-18 23:22:30 UTC 
Created attachment 171559 [details]
patch to add ngx_http_geoip2_module

OK like this? Built fine on poudriere, installed package on a test machine, all looks fine so far.
Comment 3 Matthias Breddin 2016-06-19 11:54:20 UTC 
this should also be added to www/nginx-devel
Comment 4 Sergey A. Osokin freebsd_committer freebsd_triage 2016-06-20 00:08:55 UTC 
Hi Philip,

thanks for the patch.

I've found the patch has been added an empty line at the EOL of the Makefile.
Could you please explain this.

I'd recommend to resubmit the patch.
Comment 5 FiLiS 2016-06-20 08:19:43 UTC 
Created attachment 171599 [details]
new patch w/o newline

was probably too late at night to notice the newline myself, here's the new one
Comment 6 FiLiS 2016-08-17 09:04:12 UTC 
Hej Sergey,

have you had time to look at it and maybe include it?
Comment 7 VK 2016-09-08 09:44:22 UTC 
Bump.

osa@, if you don't have enough time for this, please reassign the issue to the pool. Thank you.
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2016-09-08 09:49:27 UTC 
Comment on attachment 171599 [details]
new patch w/o newline

Maintainer timeout (3 weeks), implicit approval.
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2016-09-08 09:50:47 UTC 
Maintainer timeout (3 weeks), reset assignee.

Note: Anyone may assign this, including the maintainer (who remains cc'd, if desired).
Comment 10 Sergey A. Osokin freebsd_committer freebsd_triage 2016-11-10 03:26:34 UTC 
Hi,

sorry for delay.

Latest patch has been made several days ago.
Could you please update the patch for www/nginx and www/nginx-devel ports.

Thanks in advance.
Comment 11 commit-hook freebsd_committer freebsd_triage 2016-11-10 14:23:17 UTC 
A commit references this bug:

Author: osa
Date: Thu Nov 10 14:22:58 UTC 2016
New revision: 425846
URL: https://svnweb.freebsd.org/changeset/ports/425846

Log:
  Add one more third-party module:  ngx_http_geoip2, v.2.0.

  PR:	210294

Changes:
  head/www/nginx/Makefile
  head/www/nginx/distinfo
  head/www/nginx-devel/Makefile
  head/www/nginx-devel/distinfo
Comment 12 Sergey A. Osokin freebsd_committer freebsd_triage 2016-11-10 14:23:52 UTC 
I've just committed latest version - 2.0.

Thanks for report!