Created attachment 171492 [details] patch from a git commit, apply with patch -p1 Fallout from the recent change to use port dependencies instead of bundled versions has shown that having devel/icu installed will cause the node.js ports to fail to build. Handle this by depending on devel/icu. Bump PORTREVISION for the new dependency. Change from USES=localbase to USES=pkgconfig to pick up include and library paths for all port dependencies. PR: 210305
Comment on attachment 171492 [details] patch from a git commit, apply with patch -p1 Thanks, Bradley. Please flag the patch with maintainer-approval(+) so it appears in the "Maintainer Approved" saved search. Also a hint futurewise, you can flag your patches like that at the upload. ;)
Summary cleanup, make individual port names appear in search. Remove wrongly assigned maintainer feedback request.
The patch has issues ? Patching file www/node/Makefile using Plan A... Hunk #1 failed at 3. Hunk #2 failed at 19. Hunk #3 succeeded at 27.
Created attachment 171542 [details] corrected_patch-www_node
This one should work.
Testbuild with poudriere for node,node4, node5 jail 10.3-RELEASE-amd64 successful.
Same for 10.3-RELEASE-i386.
testbuild on 9.3a is fine.
A commit references this bug: Author: pi Date: Sat Jun 18 12:28:31 UTC 2016 New revision: 417063 URL: https://svnweb.freebsd.org/changeset/ports/417063 Log: www/node, www/node[45]: Depend on devel/icu instead of the bundled icu-small PR: 210333 Submitted by: Bradley T. Hughes <bradleythughes@fastmail.fm> (maintainer) Reviewed by: w.schwarzenfeld@utanet.at Changes: head/www/node/Makefile head/www/node4/Makefile head/www/node5/Makefile
Committed, with one small makepatch fix.
Bradley I don't like this change. icu is a HUGE port and depending on it brings absolutely nothing to node that it didn't have already. If the problem was a build failure, can node just be explicitly told to use the bundled icu-small instead?
Comment on attachment 171542 [details] corrected_patch-www_node The post-configure step isn't part of my original patch, and I don't see the need for it.
Oh, sorry overlooked that.
The post-configure was a suggestion from someone in the other PR. I tested it and forgot to remove it. But, if I read what Adam Weinberger wrote, is it considerable to keep it and change it to an ICU option?
> The post-configure was a suggestion from someone in the other PR. I tested it and forgot to remove it. > But, if I read what Adam Weinberger wrote, is it considerable to keep it and change it to an ICU option? Ideally I'd like to remove it. It seems fragile and I would prefer to find a way to make the node.js build system actually work wrt to bundled dependencies while a local copy is installed.