Bug 210637 - archivers/gtar: remove unused flags, fix license
Summary: archivers/gtar: remove unused flags, fix license
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-27 18:56 UTC by Dmitry Marakasov
Modified: 2016-06-29 15:27 UTC (History)
0 users

See Also:
naddy: maintainer-feedback+

Attachments
Patch (845 bytes, patch)
2016-06-27 18:57 UTC, Dmitry Marakasov 		no flags Details | Diff
Patch (976 bytes, patch)
2016-06-29 12:59 UTC, Dmitry Marakasov 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2016-06-27 18:56:55 UTC 
- Remove useless CPPFLAGS/LDFLAGS, this does not seem to use any ports' depends
- Fix license
- Use ${TOUCH}
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-06-27 18:57:32 UTC 
Created attachment 171882 [details]
Patch
Comment 2 Christian Weisgerber freebsd_committer freebsd_triage 2016-06-28 18:09:42 UTC 
Well, with regard to removing CPPFLAGS/LDFLAGS:

* I had to check what happens with libiconv on 9.x. (USES=iconv appears to handle it.)

* I had to check if libintl is still picked up. (It is. Probably from --prefix.)

* There still is a resulting configure difference...

 checking whether readlink handles trailing slash correctly... yes
 checking whether readlinkat signature is correct... yes
 checking for working re_compile_pattern... no
-checking libintl.h usability... yes
-checking libintl.h presence... yes
-checking for libintl.h... yes
+checking libintl.h usability... no
+checking libintl.h presence... no
+checking for libintl.h... no
 checking whether isblank is declared... (cached) yes
 checking whether rename honors trailing slash on destination... yes
 checking whether rename honors trailing slash on source... yes

  ... and because of this gnu/regex.o is built differently. I haven't examined in detail if the difference is meaningful.

Can't we just leave CPPFLAGS/LDFLAGS in place?

The license and ${TOUCH} changes are fine.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2016-06-29 12:59:32 UTC 
(In reply to Christian Weisgerber from comment #2)

> Can't we just leave CPPFLAGS/LDFLAGS in place?

Ok, but let's instead change it to USES=localbase
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2016-06-29 12:59:57 UTC 
Created attachment 171945 [details]
Patch
Comment 5 Christian Weisgerber freebsd_committer freebsd_triage 2016-06-29 14:22:32 UTC 
Sure, ok.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-06-29 15:27:51 UTC 
A commit references this bug:

Author: amdmi3
Date: Wed Jun 29 15:27:31 UTC 2016
New revision: 417776
URL: https://svnweb.freebsd.org/changeset/ports/417776

Log:
  - Fix license
  - Switch to USES=localbase
  - Switch to ${TOUCH}

  PR:		210637
  Approved by:	naddy@FreeBSD.org (maintainer)

Changes:
  head/archivers/gtar/Makefile