Created attachment 171887 [details] patch Hello, I need to update this port to 1.1.0 and switch to a maintained codebase (https://github.com/aledbevi/redmine_acts_as_taggable_on) to make www/redmine-knowledgebase plugin properly work with redmine 3.x, recently updated by swills. Unfortunately Alex has not created a gem and uploaded it to rubygems.org, so I had to create the gem and self-host it. I'm willing to take maintainership if you want, but this is something that will not likely see any changes for a couple years anyway. I expect this fork of the codebase to be fully backwards compatible. I've seen no indication otherwise. The only port in the tree using this port is my new www/redmine-knowledgebase port. Thanks
Hello Mark, since i wrote the update of redmine to 3.x i grep this issue ;) I'm not sure if i really got your problem. Your link to a "maintained codebase" points to https://github.com/aledbevi/redmine_acts_as_taggable_on, but this is a 404 page. Also the user "aledbevi" did not exist on github (or is now deleted). Your patch changes it to https://github.com/alexbevi/redmine_acts_as_taggable_on, which works. The master is https://github.com/hdgarrood/redmine_acts_as_taggable_on, but there is the latest release 1.1.0. But when reading your committ-log you want to force the usage of rails4. You did this by switching from www/rubygem-acts-as-taggable-on to www/rubygem-acts-as-taggable-on3. But this are different versions. If www/rubygem-redmine_acts_as_taggable_on relies on the old version of rubygem-acts-as-taggable-on this will cause problems. So in conclusion: you forked the project and patch it to work with the new version of act-as-taggable-on to avoid the usage of rails 3? Am i correct? If this is the case there is good news for you: this is not needed. I'm currently in progress to remove Rails 3 from the portstree. It is just possible to patch www/rubygem-acts-as-taggable-on to use rails 4. I have a patch for this (with a bunch of others). Are you interested in testing? Greetings, Torsten
(In reply to Torsten Zuehlsdorff from comment #1) Yes, sorry, I typoed the name. tl;dr: https://github.com/hdgarrood/redmine_acts_as_taggable_on is what the port is currently using. This is unmaintained. I want to switch the port to this fork: https://github.com/alexbevi/redmine_acts_as_taggable_on This is maintained as necessary. An extremely popular redmine plugin called "Knowledgebase" is by this same author and requires redmine_acts_as_taggable_on. His fork is the only one that supports Rails4 and Redmine 3, so we should switch the port to this if you're working on removing Rails3. As it currently stands my port www/redmine-knowledgebase is broken due to the Redmine upgrade. This proposed patch is needed to fix it.
Ah, understood. I will test the patch tomorrow :)
Created attachment 172169 [details] revised patch v1 Hello Mark, i'm nearly fine with the patch. I just dropped the PORTREVISION=0 which isn't needed. Since i'm new i need approval of an mentor. I will commit the patch when the approval receives :) Just out of interesting: do you know if the gem works together with redmine 3.3? Greetings, Torsten
Approved. With hat: ruby@
(In reply to Torsten Zuehlsdorff from comment #4) I believe it is supposed to work against redmine 3.3, but I've only tested it against redmine 3.2.3 which is in ports.
A commit references this bug: Author: feld Date: Wed Jul 6 14:04:13 UTC 2016 New revision: 418132 URL: https://svnweb.freebsd.org/changeset/ports/418132 Log: www/rubygem-redmine_acts_as_taggable_on: Update to 1.1.0 This update changes to a different upstream fork where there is now support for Redmine 3.x. This is maintained by the same author who created the Redmine Knowledgebase plugin which requires this gem. PR: 210644 Approved by: maintainer (zi) Changes: head/www/rubygem-redmine_acts_as_taggable_on/Makefile head/www/rubygem-redmine_acts_as_taggable_on/distinfo head/www/rubygem-redmine_acts_as_taggable_on/pkg-descr
A commit references this bug: Author: feld Date: Wed Jul 6 14:52:00 UTC 2016 New revision: 418140 URL: https://svnweb.freebsd.org/changeset/ports/418140 Log: MFH: r418132 www/rubygem-redmine_acts_as_taggable_on: Update to 1.1.0 This update changes to a different upstream fork where there is now support for Redmine 3.x. This is maintained by the same author who created the Redmine Knowledgebase plugin which requires this gem. PR: 210644 Approved by: maintainer (zi) Approved by: ports-secteam (with hat) Changes: _U branches/2016Q3/ branches/2016Q3/www/rubygem-redmine_acts_as_taggable_on/Makefile branches/2016Q3/www/rubygem-redmine_acts_as_taggable_on/distinfo branches/2016Q3/www/rubygem-redmine_acts_as_taggable_on/pkg-descr