Bug 210654 - shells/bash: Removal of the stray patch preventing unicode chars handling
Summary: shells/bash: Removal of the stray patch preventing unicode chars handling
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-28 09:29 UTC by Yuri Victorovich
Modified: 2016-06-28 11:57 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
patch (767 bytes, patch)
2016-06-28 09:29 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2016-06-28 09:29:37 UTC 
Created attachment 171905 [details]
patch

Hi Emanuel,

I saw you just committed the patch https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206903

However, there is the patch there that disables HAVE_ICONV when NLS=off that breaks the unicode support. I probably missed it in 206903.

Please commit this patch, it restores the unicode support in the case of NLS=off, as I just verified.

Thanks,
Yuri
Comment 1 Emanuel Haupt freebsd_committer freebsd_triage 2016-06-28 11:50:24 UTC 
Test case:

PS1=$'\\[\e[0;38;5;202m\\]\u2514\u2023\\[\e[0m\\] '
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-06-28 11:56:44 UTC 
A commit references this bug:

Author: ehaupt
Date: Tue Jun 28 11:56:03 UTC 2016
New revision: 417709
URL: https://svnweb.freebsd.org/changeset/ports/417709

Log:
  Remove stray ICONV patch that breaks unicode support if NLS is disabled.

  PR:             210654
  Submitted by:   yuri@rawbw.com

Changes:
  head/shells/bash/Makefile
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2016-06-28 11:57:25 UTC 
Committed, thanks!