Created attachment 171957 [details] svn diff for x11/xvt This pr(1) updates x11/xvt to it's latest version (3.0.1). Changes to source Fix partially corrupt xvt(1) man file massive documentation updates, and rewrites light code changes Port changes bumps PORTVERSION slight change to COMENT, and pkg-descr adds PORTDOCS That's it! passes all tests -- QA LOG attached to this pr(1) Thanks! --Chris
Created attachment 171958 [details] QA LOG for x11/xvt
There are a couple of issues during QA and checks, could you double-check? During make checksum: xvt-3.0.1: Makefile warning: in desktop entry #1 (xvt): category X-XFCE is not a valid desktop category xvt-3.0.1: Makefile warning: in desktop entry #1 (xvt): category X-Xfce-Toplevel is not a valid desktop category Later during stage-qa: ====> Running Q/A tests (stage-qa) Error: /usr/local/bin/xvt is linked to /usr/local/lib/libX11.so.6 from x11/libX11 but it is not declared as a dependency Warning: you need USE_XORG+=x11 ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: %%DOCSDIR%%/xvt.1.html Error: Missing: %%DOCSDIR%%/xvtRef.html Error: Missing: %%DOCSDIR%%/xvtRef.txt ===> Error: Plist issues found. *** Error code 1 Stop. make: stopped in /usr/ports/x11/xvt
(In reply to Thomas Zander from comment #2) > There are a couple of issues during QA and checks, could you double-check? > > During make checksum: > xvt-3.0.1: Makefile warning: in desktop entry #1 (xvt): category X-XFCE is > not a valid desktop category > xvt-3.0.1: Makefile warning: in desktop entry #1 (xvt): category > X-Xfce-Toplevel is not a valid desktop category > > Later during stage-qa: > ====> Running Q/A tests (stage-qa) > Error: /usr/local/bin/xvt is linked to /usr/local/lib/libX11.so.6 from > x11/libX11 but it is not declared as a dependency > Warning: you need USE_XORG+=x11 > ====> Checking for pkg-plist issues (check-plist) > ===> Parsing plist > ===> Checking for items in STAGEDIR missing from pkg-plist > ===> Checking for items in pkg-plist which are not in STAGEDIR > Error: Missing: %%DOCSDIR%%/xvt.1.html > Error: Missing: %%DOCSDIR%%/xvtRef.html > Error: Missing: %%DOCSDIR%%/xvtRef.txt > ===> Error: Plist issues found. > *** Error code 1 > > Stop. > make: stopped in /usr/ports/x11/xvt Hello, Thomas. Thanks for your time. The X-XFCE error is a red herring, and is required for x11-wm/xfce4. If not provided, xfce4 will not automatically add it to it's menu. As to the plist complaint; I'm trying to avoid bloating this with bsd.port.options.mk. Please see the new svn diff file I've attached, which quiets portlint. :-) Thanks again! --Chris
Created attachment 171989 [details] updated svn diff for x11/xvt updated svn diff for x11/xvt
Created attachment 171993 [details] svn diff for x11/xvt (version 2) Let's diff the right Makefile this time! Sorry. This one's the right one -- promise. :-) --Chris
A commit references this bug: Author: riggs Date: Fri Jul 1 10:32:24 UTC 2016 New revision: 417872 URL: https://svnweb.freebsd.org/changeset/ports/417872 Log: Update to upstream revision 3.0.1, add DOCS OPTION Detailed log: - Update to upstream revision 3.0.1 - Fix partially corrupt xvt(1) man file - Documentation updates - Slight change to COMMENT, and pkg-descr - Add PORTDOCS - Pet portlint PR: 210711 Submitted by: portmaster@bsdforge.com (maintainer) Changes: head/x11/xvt/Makefile head/x11/xvt/distinfo head/x11/xvt/pkg-descr head/x11/xvt/pkg-plist