Comment 1 Matthew Seaman 2016-07-06 13:30:15 UTC

The MOVED entry would have the effect that users of the existing security/hashcat will automatically update to security/hashcat-legacy.

If the intention is that users should update to the new-codebase version of security/hashcat instead, then I should copy security/hashcat to security/hashcat-legacy and apply the upgrade to security/hashcat in close proximity.  In which case, could you add a patch with the security/hashcat changes to this PR please? For this alternative an UPDATING entry to suggest installing hashcat-legacy if desired would be a good idea.

I'm almost done with the new port. I'll attach it soon. The UPDATING entry will be necessary because the new version requires a working OpenCL runtime (but is CPU/GPU agnostic).

I'm attaching changelog in the URL field.

Created attachment 172177 [details]
security/hashcat: 3.00

Here you go. This passes "portlint -A" and works on 10.3/11.0 i386/amd64.

There should be an UPDATING entry to the effect of what's in pkg-message.

Created attachment 172179 [details]
security/hashcat: 3.00

I apologize. I attached the wrong patch.

Comment 6 Matthew Seaman 2016-07-07 20:33:46 UTC

Created attachment 172212 [details]
poudriere testport output

Sorry -- hashcat 3.00 is failing poudriere testport.  Looks like it expects gcc to be installed but the port isn't adding gcc as a build depends.

hashcat-legacy builds on 10.1 amd64 but fails on 9.3 amd64 due to a missing header.

Nikolai, thanks for your patches. Please note you can confirm QA only by mentioning which tests passed (or failed), like "Poudriere 10.3 amd64 build passed", or something. Attaching build logs is not required and they only clutter the Bugzilla database.

Comment 8 Matthew Seaman 2016-07-09 09:14:06 UTC

(In reply to Vladimir Krstulja from comment #7)

Careful there Vladimir.  It was me who attached the poudriere testport output.

Created attachment 172294 [details]
security/hashcat: 3.00

Apologies, I was trying to mix/match svn/portsnap with my poudriere.
This is the correct patch, which passed on 10.3 amd64/i386 and 11.0 amd64.

Both hashcat and hashcat-legacy should already be marked BROKEN_FreeBSD_9.
The previous version of hashcat was BROKEN_FreeBSD_9 as well.

Comment 10 Matthew Seaman 2016-07-11 06:02:10 UTC

Sorry -- this is still failing my poudriere testbuilds.  It requires a C compiler called exactly 'gcc' and that does not exist without installing one of the ports versions.

I'm sorry. I can't reproduce the failure. It uses /usr/bin/cc to build for me.

Created attachment 172392 [details]
10.3/amd64 testport log

Here is my log.

Created attachment 172393 [details]
10.1/amd64 testport

Here is another log, from 10.1/amd64.

Comment 14 commit-hook 2016-07-11 21:21:42 UTC

A commit references this bug:

Author: matthew
Date: Mon Jul 11 21:21:36 UTC 2016
New revision: 418409
URL: https://svnweb.freebsd.org/changeset/ports/418409

Log:
  Upgrade to 3.00

  This is a major rewrite that combines the codebases of the former
  hashcat (running on the main CPU) and oclHashcat (running on the GPU).

  Because of the extent of the changes, the previous version will still
  remain available, renamed to 'hashcat-legacy' (following upstream)

  ChangeLog: https://github.com/hashcat/hashcat/releases/tag/v3.00

  PR:		210873
  Submitted by:	lifanov@mail.lifanov.com (maintainer)

Changes:
  head/security/hashcat/Makefile
  head/security/hashcat/distinfo
  head/security/hashcat/files/patch-include_common.h
  head/security/hashcat/files/patch-include_ext__OpenCL.h
  head/security/hashcat/files/patch-src_Makefile
  head/security/hashcat/files/patch-src_hashcat-cli.c
  head/security/hashcat/files/patch-src_hashcat.c
  head/security/hashcat/files/patch-src_shared.c
  head/security/hashcat/pkg-message
  head/security/hashcat/pkg-plist

Comment 15 commit-hook 2016-07-11 21:27:44 UTC

A commit references this bug:

Author: matthew
Date: Mon Jul 11 21:27:19 UTC 2016
New revision: 418410
URL: https://svnweb.freebsd.org/changeset/ports/418410

Log:
  Rename security/hashcat to security/hashcat-legacy
  (Tracking upstream change)

  security/hashcat has been extensively reworked and may now utilize
  OpenCL to run on GPUs etc.  Most people are expected to upgrade to
  security/hashcat (hashcat-3.00); this port is being kept in order to
  support people for whom hashcat-3.00 may not be compatible.

  Add explicit dependency on math/gmp

  PR:		210873
  Submitted by:	lifanov@mail.lifanov.com (maintainer)

Changes:
  head/security/Makefile
  head/security/hashcat-legacy/
  head/security/hashcat-legacy/Makefile
  head/security/hashcat-legacy/distinfo

Comment 16 Matthew Seaman 2016-07-11 21:29:00 UTC

Apologies.  I had at least one of the patches corrupted, which broke my test builds.  Everything is fine!

Committed, thanks!