Bug 211173 - sysutils/atop: Fails to build in head r302904 due to flag rename (P_KPROC -> P_KTHREAD)
Summary: sysutils/atop: Fails to build in head r302904 due to flag rename (P_KPROC -> ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-17 13:26 UTC by Matthias Apitz
Modified: 2016-07-31 16:50 UTC (History)
3 users (show)

See Also:
pi: maintainer-feedback-
pi: merge-quarterly+


Attachments
patch (1003 bytes, patch)
2016-07-17 19:46 UTC, Kurt Jaeger
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Apitz 2016-07-17 13:26:51 UTC
the port fails to comile in 12-CURRENT:

> clang -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -DFREEBSD -c photoproc.c -o photoproc.o
> photoproc.c:397:51: error: use of undeclared identifier 'P_KTHREAD'
>             ((pp->ki_flag & P_SYSTEM ) || (pp->ki_flag & P_KTHREAD)))
>                                                          ^
> photoproc.c:464:75: error: use of undeclared identifier 'P_KTHREAD'
>                         if (filterkernel && ((pbase->ki_flag & P_SYSTEM ) || (pbase->ki_flag & P_KTHREAD)))
>                                                                                                ^
> photoproc.c:577:74: error: use of undeclared identifier 'P_KTHREAD'
>                 if (filterkernel && ((pbase->ki_flag & P_SYSTEM ) || (pbase->ki_flag & P_KTHREAD))) 
>                                                                                        ^
> photoproc.c:674:51: error: use of undeclared identifier 'P_KTHREAD'
>                 if ((pp->ki_flag & P_SYSTEM ) || (pp->ki_flag & P_KTHREAD))
>                                                                 ^
> photoproc.c:690:44: error: use of undeclared identifier 'P_KTHREAD'
>             curtask->cpu.rtprio = ((pp->ki_flag & P_KTHREAD) ? pp->ki_pri.pri_native :
>                                                   ^
> photoproc.c:694:44: error: use of undeclared identifier 'P_KTHREAD'
>             curtask->cpu.rtprio = ((pp->ki_flag & P_KTHREAD) ? pp->ki_pri.pri_native :

Konstantin Belousov <kostikbel@gmail.com> commented in freebsd-ports@:

The flag was renamed to P_KPROC in HEAD/stable-12.
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2016-07-17 19:46:33 UTC
Created attachment 172612 [details]
patch

portlint is OK, testbuild is fine.
Comment 2 Matthias Apitz 2016-07-19 07:43:08 UTC
with this patch it compiles and runs fine on r302904 (amd64)
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-07-31 10:32:01 UTC
A commit references this bug:

Author: pi
Date: Sun Jul 31 10:31:31 UTC 2016
New revision: 419354
URL: https://svnweb.freebsd.org/changeset/ports/419354

Log:
  sysutils/atop: fix after r302904 due to flag rename (P_KPROC -> P_KTHREAD)

  PR:		211173
  Approved by:	samm@os2.kiev.ua (maintainer timeout)
  MFH:		2016Q3

Changes:
  head/sysutils/atop/Makefile
  head/sysutils/atop/files/patch-atop.h
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2016-07-31 10:39:09 UTC
The change P_KPROC -> P_KTHREAD was in r295435.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-31 10:43:48 UTC
Comment on attachment 172612 [details]
patch

maintainer timeout, implicit approval
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-07-31 16:50:03 UTC
A commit references this bug:

Author: pi
Date: Sun Jul 31 16:49:18 UTC 2016
New revision: 419394
URL: https://svnweb.freebsd.org/changeset/ports/419394

Log:
  sysutils/atop: fix after r302904 due to flag rename (P_KPROC -> P_KTHREAD)

  PR:		211173
  MFH:		r419354
  Approved by:	ports-secteam (junovitch)

Changes:
_U  branches/2016Q3/
  branches/2016Q3/sysutils/atop/Makefile
  branches/2016Q3/sysutils/atop/files/patch-atop.h