Bug 211203 - databases/postgis22: compile error: unknown type name 'LWORD'
Summary: databases/postgis22: compile error: unknown type name 'LWORD'
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on: 214906
Blocks:
  Show dependency treegraph
 
Reported: 2016-07-18 16:18 UTC by Robert Kruus
Modified: 2016-12-01 10:20 UTC (History)
3 users (show)

See Also:
vlad-fbsd: maintainer-feedback+
koobs: merge-quarterly?


Attachments
Patch for force include the headers from build directory first. (483 bytes, patch)
2016-07-18 16:18 UTC, Robert Kruus
no flags Details | Diff
patch to circumstance the update dilemma (1.12 KB, patch)
2016-07-19 14:48 UTC, Rainer Hurling
rhurlin: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kruus 2016-07-18 16:18:57 UTC
Created attachment 172667 [details]
Patch for force include the headers from build directory first.

Potential fix for bug #210453 (I added a comment to that one already).
If the include order is changed to find the newer headers first, one can compile the newer version of postgis with the old version still installed.
Comment 1 Rainer Hurling freebsd_committer freebsd_triage 2016-07-18 17:43:23 UTC
Thanks for your analysis and suggestion.

I was just preparing exactly the same patch, you published ;)

Some short test of the patched databases/postgis22 did no show any misbehaviour to me. So probably, the patch should be ok?

If you could confirm, that the patched version *works*  for you, I would set the maintainer-feedback flag to '+', thanks.
Comment 2 Robert Kruus 2016-07-18 18:39:51 UTC
Seems to work fine here -- though I am just really using it for point data so no real extensive testing done.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-19 13:17:46 UTC
Comment on attachment 172667 [details]
Patch for force include the headers from build directory first.

@Rainer, you should be able to set maintainer-approval to + on the attachment now, once QA is confirmed

A unified diff against the port (via make makepatch) would also be good.
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2016-07-19 14:48:39 UTC
Created attachment 172725 [details]
patch to circumstance the update dilemma

Ok, thanks Robert for trying and Kubilay for his incitations.

I did some tests from within graphics/qgis and math/saga and it seems to work there, too.

QA:
- A new unified diff is attached, tested it with Poudriere (9.3i+a, 10.3i+a and HEADi+a). 
- 'portlint -AC' gives some warnings about relativ paths, but this is in the replacing section.


So it should be ready for commit now.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-20 08:17:11 UTC
@Rainer great stuff :)
Comment 6 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2016-11-28 13:59:51 UTC
this has been fixed upstream https://trac.osgeo.org/postgis/ticket/3604 and made it's way into 2.2.3 - so this bug will be obsoleted by bug #214906
Comment 7 Rainer Hurling freebsd_committer freebsd_triage 2016-11-28 16:32:48 UTC
(In reply to Christoph Moench-Tegeder from comment #6)

As the maintainer of databases/postgis22, I also would suggest to close this bug and to commit the patch from bug #214906 instead.

Many thanks in advance.
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-11-30 21:51:45 UTC
A commit references this bug:

Author: cmt
Date: Wed Nov 30 21:51:08 UTC 2016
New revision: 427461
URL: https://svnweb.freebsd.org/changeset/ports/427461

Log:
  update databases/postgis22 to 2.2.4

  also, fixes build when older version is installed[1]

  PR:		214906, 211203 [1]
  Reported by:	robert.kruus@utoronto.ca [1]
  Approved by:	rhurlin@gwdg.de (maintainer), rene (mentor)
  MFH:		2016Q4

Changes:
  head/databases/postgis22/Makefile
  head/databases/postgis22/distinfo
  head/databases/postgis22/pkg-plist
Comment 9 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2016-11-30 21:54:32 UTC
fixed by ports r427461
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-12-01 10:20:58 UTC
A commit references this bug:

Author: cmt
Date: Thu Dec  1 10:19:51 UTC 2016
New revision: 427484
URL: https://svnweb.freebsd.org/changeset/ports/427484

Log:
  MFH: r427461

  update databases/postgis22 to 2.2.4

  also, fixes build when older version is installed[1]

  PR:		214906, 211203 [1]
  Reported by:	robert.kruus@utoronto.ca [1]
  Approved by:	rhurlin@gwdg.de (maintainer), rene (mentor)

  Approved by:	ports-secteam (junovitch)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/databases/postgis22/Makefile
  branches/2016Q4/databases/postgis22/distinfo
  branches/2016Q4/databases/postgis22/pkg-plist