Bug 211217 - databases/sqlitebrowser: Add TOOLKIT option to select the Qt version
Summary: databases/sqlitebrowser: Add TOOLKIT option to select the Qt version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL: https://reviews.freebsd.org/D7253
Keywords: easy, feature, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-07-19 09:52 UTC by Tobias C. Berner
Modified: 2016-09-30 21:49 UTC (History)
3 users (show)

See Also:
rm: maintainer-feedback+
koobs: merge-quarterly?

Attachments
Add TOOLKIT option (789 bytes, patch)
2016-07-19 09:52 UTC, Tobias C. Berner 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias C. Berner freebsd_committer freebsd_triage 2016-07-19 09:52:07 UTC 
Created attachment 172708 [details]
Add TOOLKIT option

databases/sqlitebrowser can be built against either Qt4 or Qt5.

The attached patch adds an OPTIONS_SINGLE to select between QT4[default] and QT5.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2016-07-19 09:52:07 UTC 
Maintainer informed via mail
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-19 10:01:12 UTC 
This may be better as individual -qt4 -qt5 slave ports (thus packages), though I haven't looked at how other ports have implemented such an option or if a policy preference exists for it. The option name may also need to be changed depending on policy / defacto standards in existing ports, or the presence of existing (and appropriate) options in bsd.options.desc.mk
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2016-07-19 12:04:54 UTC 
Also, opt_CMAKE_BOOL is a thing now:

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html#options-cmake_bool
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2016-07-19 20:17:10 UTC 
I created a review [1] to create the slave ports suggested in comment#2


[1] https://reviews.freebsd.org/D7253
Comment 5 Loïc Bartoletti freebsd_committer freebsd_triage 2016-09-05 21:25:17 UTC 
I joined this request in the update of sqlitebrowser 3.8.0 to 3.9.0.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212395
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-09-13 20:07:27 UTC 
A commit references this bug:

Author: tcberner
Date: Tue Sep 13 20:06:29 UTC 2016
New revision: 422073
URL: https://svnweb.freebsd.org/changeset/ports/422073

Log:
  Add new port databases/sqlitebrowser-qt5 as slaveport of databases/sqlitebrowser

  Add a new port databases/sqlitebrowser-qt5 as slaveport of the existing
  databases/sqlitebrowser.

  PR:             211217
  Reviewed by:    mat
  Approved by:    rakuco (mentor)
  Differential Revision:  https://reviews.freebsd.org/D7253

Changes:
  head/databases/Makefile
  head/databases/sqlitebrowser/Makefile
  head/databases/sqlitebrowser-qt5/
  head/databases/sqlitebrowser-qt5/Makefile
  head/databases/sqlitebrowser-qt5/distinfo
  head/databases/sqlitebrowser-qt5/files/
  head/databases/sqlitebrowser-qt5/pkg-descr
  head/databases/sqlitebrowser-qt5/pkg-plist
Comment 7 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-09-30 21:49:06 UTC 
Committed. Closing.