Bug 211306 - net/libzmq4: Update to 4.1.5, Add NORM and MANPAGES options
Summary: net/libzmq4: Update to 4.1.5, Add NORM and MANPAGES options
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kubilay Kocak
URL: https://github.com/zeromq/libzmq/pull...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-07-23 00:42 UTC by Eric Camachat
Modified: 2016-08-11 12:24 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly+


Attachments
Update net/libzmq4 to 4.1.5 (5.29 KB, patch)
2016-07-23 00:42 UTC, Eric Camachat
no flags Details | Diff
Add norm support (6.75 KB, patch)
2016-07-27 17:06 UTC, Eric Camachat
eric: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Camachat 2016-07-23 00:42:52 UTC
Created attachment 172850 [details]
Update net/libzmq4 to 4.1.5

Update net/libzmq4 to 4.1.5
Comment 1 Eric Camachat 2016-07-27 17:06:24 UTC
Created attachment 173052 [details]
Add norm support

Add NORM (NACK-Oriented Reliable Multicast) option, ref:
http://zeromq.org/topics:norm-protocol-transport
http://www.nrl.navy.mil/itd/ncs/products/norm
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-28 09:29:08 UTC
Thanks for your contribution Eric.

Minor nits (I can fix them)

* NORM option is out of order (alpha sort)
* Additional LIBS (and LDFLAGS if necessary) can be provided in the port Makefile. Did you test whether libzqm's configure honours them? If so, its preferable to use those constructs over a patch. If not, we want to submit a bug report/pull request upstream to get it fixed (carrying the patch locally in the mean time)
Comment 3 Eric Camachat 2016-07-28 15:06:38 UTC
Patch has been merged onto upstream, https://github.com/zeromq/libzmq/pull/2066
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-28 15:10:06 UTC
Ahh perfect, thank you Eric
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-08-11 10:27:51 UTC
A commit references this bug:

Author: koobs
Date: Thu Aug 11 10:27:27 UTC 2016
New revision: 420056
URL: https://svnweb.freebsd.org/changeset/ports/420056

Log:
  net/libzmq4: Add NORM option, Disable -Werror

  - Add NORM option and helpers [1], no default.
  - Backport upstream pull request #2066. [1][2]
  - Override default -Werror in build.

  [2] https://github.com/zeromq/libzmq/pull/2066

  PR:		211306 (part 1 of 2) [1]
  Submitted by:	Eric Camachat <eric camachat org> [1]
  MFH:		2016Q3

Changes:
  head/net/libzmq4/Makefile
  head/net/libzmq4/distinfo
  head/net/libzmq4/files/
  head/net/libzmq4/files/patch-configure
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-08-11 10:54:58 UTC
A commit references this bug:

Author: koobs
Date: Thu Aug 11 10:54:25 UTC 2016
New revision: 420059
URL: https://svnweb.freebsd.org/changeset/ports/420059

Log:
  MFH: r420056 - net/libzmq4: Add NORM option, Disable -Werror

  - Add NORM option and helpers [1], no default.
  - Backport upstream pull request #2066. [1][2]
  - Override default -Werror in build.

  [2] https://github.com/zeromq/libzmq/pull/2066

  PR:		211306 (part 1 of 2) [1]
  Submitted by:	Eric Camachat <eric camachat org> [1]

   - Resolve conflict from missing r418449

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2016Q3/
  branches/2016Q3/net/libzmq4/Makefile
  branches/2016Q3/net/libzmq4/distinfo
  branches/2016Q3/net/libzmq4/files/
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-08-11 12:16:09 UTC
A commit references this bug:

Author: koobs
Date: Thu Aug 11 12:15:21 UTC 2016
New revision: 420065
URL: https://svnweb.freebsd.org/changeset/ports/420065

Log:
  net/libzmq4: Update to 4.1.5, Add MANPAGES option

  - Update PORTVERSION and distinfo checksum (4.1.5)
  - Update pkg-plist accordingly (library minor version bump)
  - Update MASTER_SITES (upstream moved to GitHub releases)
  - Add MANPAGES option and dependencies (xmlto/asciidoc (sorry!) as they
    now need to be built. Add OPTIONS_SUB and update pkg-plist accordingly
  - Re-patch configure after minor updates since 4.1.4
  - Sort pkg-plist

  PR:		211306 (part two of two)
  Submitted by:	Eric Camachat <eric camachat org>

Changes:
  head/net/libzmq4/Makefile
  head/net/libzmq4/distinfo
  head/net/libzmq4/files/patch-configure
  head/net/libzmq4/pkg-plist
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2016-08-11 12:24:45 UTC
Committed (in 3 parts) with minor changes, so fixes could get merged to quarterly.

First two (comment 5, comment 6) merged, last one (comment 7 for 4.1.5 update + MANPAGES) not 

Thank you for your contribution Eric