Bug 211356 - editors/emacs-devel: update to 25.1-rc1
Summary: editors/emacs-devel: update to 25.1-rc1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-25 05:05 UTC by Joseph Mingrone
Modified: 2016-07-27 07:14 UTC (History)
0 users

See Also:
ashish: maintainer-feedback+

Attachments
svn diff to update editors/emacs-devel to 25.1-rc1 (2.40 KB, patch)
2016-07-25 05:05 UTC, Joseph Mingrone 		no flags Details | Diff
Minor update to provided diff (1.28 KB, patch)
2016-07-25 05:55 UTC, Ashish SHUKLA 		no flags Details | Diff
another svn diff to fix build failure when XWIDGETS option is chosen w/o GTK3 (1.29 KB, patch)
2016-07-27 03:13 UTC, Joseph Mingrone 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Mingrone freebsd_committer freebsd_triage 2016-07-25 05:05:27 UTC 
Created attachment 172960 [details]
svn diff to update editors/emacs-devel to 25.1-rc1

portlint: Suggests adding an option for NLS, but configuring with --disable-nls still causes libintl.so to be linked when any of the GTK2, GTK3, or SVG options are on.  Otherwise no warnings or errors.

testport: OK (poudriere: 9.3-RELEASE-p44, i386,  default options)
testport: OK (poudriere: 9.3-RELEASE-p44, amd64, default options)
testport: OK (poudriere: 10.3-RELEASE-p5, i386,  default options)
testport: OK (poudriere: 10.3-RELEASE-p5, amd64, default options)
Comment 1 Ashish SHUKLA freebsd_committer freebsd_triage 2016-07-25 05:55:56 UTC 
Created attachment 172962 [details]
Minor update to provided diff

Hi Joseph,

Thanks for providing the diff.

I have added EMACS_VER= ${PORTVERSION:R} line, thus keeping changes to minimum. I have not got chance to build it yet, will do it later in the evening, and commit it, although seeing an emacs update excited me, so I'm replying now.

And also just so I don't forget, this will need a change for version number to bsd.emacs.mk as well.

Thanks again, I will let you know how it goes.

Ashish
Comment 2 Joseph Mingrone freebsd_committer freebsd_triage 2016-07-26 17:47:21 UTC 
Hi Ashish,

Sounds good.

There are lots of things to be excited about in 25.1. :)

I'm glad to hear you will be able to commit this soon (assuming you don't encounter any problems), so that users will have an opportunity to test for bugs before the final release.

Cheers,

Joseph
Comment 3 Joseph Mingrone freebsd_committer freebsd_triage 2016-07-27 03:13:20 UTC 
Created attachment 173027 [details]
another svn diff to fix build failure when XWIDGETS option is chosen w/o GTK3

Change XWIDGETS_IMPLIES=X11 to XWIDGETS_IMPLIES=GTK3 to prevent build failure during the configure stage.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-07-27 07:12:53 UTC 
A commit references this bug:

Author: ashish
Date: Wed Jul 27 07:12:25 UTC 2016
New revision: 419164
URL: https://svnweb.freebsd.org/changeset/ports/419164

Log:
  editors/emacs-devel:
   - Update to 25.1-rc1[1]
   - Add IMPLIES condition for XWIDGETS option[1]

  Mk/bsd.emacs.mk:
   - Add block for emacs-nox11[2]
   - Update emacs-devel block with new EMACS_VER

  PR:		211356 [1]
  Submitted by:	Joseph Mingrone <jrm@ftfl.ca> [1],
  		matthew (via private email) [2]

Changes:
  head/Mk/bsd.emacs.mk
  head/editors/emacs-devel/Makefile
  head/editors/emacs-devel/distinfo
Comment 5 Ashish SHUKLA freebsd_committer freebsd_triage 2016-07-27 07:14:05 UTC 
Commited, thanks!