Bug 211454 - math/arpack-ng: Update to 3.4.0
Summary: math/arpack-ng: Update to 3.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-30 05:30 UTC by Iblis Lin
Modified: 2016-08-18 16:20 UTC (History)
1 user (show)

See Also:


Attachments
arpack-ng 3.4.0 patch (1.84 KB, patch)
2016-07-30 05:30 UTC, Iblis Lin
iblis.dif01: maintainer-approval+
Details | Diff
arpacj-ng 3.4.0 patch v2 (2.97 KB, patch)
2016-08-18 07:52 UTC, Iblis Lin
iblis.dif01: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Iblis Lin 2016-07-30 05:30:31 UTC
Created attachment 173109 [details]
arpack-ng 3.4.0 patch

- The repo hosts on github now. So i change the master site to GH.

- The full changelog is here:
  https://github.com/opencollab/arpack-ng/blob/master/CHANGES


portlint:
    WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "+=".
    WARN: Makefile: "PKGNAMESUFFIX" has to appear earlier.
    0 fatal errors and 2 warnings found.

testport:
    10.3-RELEASE, amd64, tested.
    9.3-RELEASE, amd64, tested.
Comment 1 Pawel Pekala freebsd_committer freebsd_triage 2016-08-17 17:58:16 UTC
This update has plist issues when option MPI=on:

====> Running Q/A tests (stage-qa)
Warning: 'lib/libparpack.so.2.0.0' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: bin/pcndrv1
Error: Missing: bin/pdndrv1
Error: Missing: bin/pdndrv3
Error: Missing: bin/pdsdrv1
Error: Missing: bin/psndrv3
Error: Missing: bin/pssdrv1
Error: Missing: bin/pzndrv1
===> Error: Plist issues found.
*** Error code 1
Comment 2 Iblis Lin 2016-08-18 07:52:55 UTC
Created attachment 173813 [details]
arpacj-ng 3.4.0 patch v2

I figured out that those file is examples and they will not be installed ( https://github.com/opencollab/arpack-ng/blob/master/CHANGES#L53).

Patch v2:

    - add a new option: `EXAMPLES`

    - add `PORTEXAMPLES`

    - add target `post-install-EXAMPLES-on`

    - correct plist

Please test this patch, i only tested it with `port test`.
My poudriere build failed with `MPI=on`, because one of dependecies of MPI, dbus, built failed....
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-08-18 16:20:22 UTC
A commit references this bug:

Author: pawel
Date: Thu Aug 18 16:19:57 UTC 2016
New revision: 420410
URL: https://svnweb.freebsd.org/changeset/ports/420410

Log:
  - Update to version 3.4.0, now hosted on GitHub [1]
  - Add EXAMPLES option [1]
  - Fix COMMENT declaration, use ?= so that slave can overide it
  - Add LICENSE_FILE
  - Convert to options helpers, test framework
  - Remove MPI option and move it's all functionality to slave port
    This allows removal of setting PKGNAMESUFFIX in master port depending
    on options selected which is deprecated. Move LIB_DEPENDS on mpich2
    to slave, declare CONFLICTS_INSTALL, MPICH_ARG in such way that can
    be overidden by the slave.

  PR:		211454 [1]
  Submitted by:	Iblis Lin [1]

Changes:
  head/math/arpack-ng/Makefile
  head/math/arpack-ng/distinfo
  head/math/arpack-ng/pkg-plist
  head/math/arpack-ng-mpich/Makefile