Created attachment 173112 [details] iortcw.shar Return to Castle Wolfenstein is a military- and occult-themed first-person shooter game in a Second World War setting, originally released in 2001. It is a sequel to Wolfenstein 3D. This port contains the iortcw game engines for the single-player campaign and multiplayer, based on ioquake3 and the GPL source releases of RtCW. Return to Castle Wolfenstein requires non-distributable game data files, which you have to install manually (see pkg-message). WWW: https://github.com/iortcw/iortcw/ ------- This port should obsolete games/linux-rtcw which has no maintainer at the moment and could possibly be removed after importing this one. Thanks to zspider on the FreeBSD Forums for testing and giving me the idea for this port. Portlint ok, Poudriere testport on FreeBSD 9.3/{amd64,i386} and FreeBSD 10.3/amd64 ok.
You can add the LICENSE_FILE LICENSE_FILE= ${WRKSRC}/MP/COPYING.txt and remove the script names from ${PREFIX} target post-install-MP-on: ${INSTALL_SCRIPT} ${WRKDIR}/iowolfmp ${STAGEDIR}${PREFIX}/bin ${INSTALL_SCRIPT} ${WRKDIR}/iowolfded ${STAGEDIR}${PREFIX}/bin post-install-SP-on: ${INSTALL_SCRIPT} ${WRKDIR}/iowolfsp ${STAGEDIR}${PREFIX}/bin
Created attachment 173115 [details] iortcw.shar (In reply to Carlos J. Puga Medina from comment #1) The license file doesn't exist in the source tarball, so I didn't add LICENSE_FILE. It was a recent addition to the repository. I can do this when the next version is out. Dropped the script names.
OK, waiting for amdmi3@ review and approval.
Looking at it
Mostly LGTM. I'd just add a missing tab after USE_GL, and I'm confused by opusfile dependency: does it not use shared library from that port? Need poudriere build to finish to check out logs.
Looked through logs, only include files from opusfile are used, so the dependency is correct. So apart from missing tab on USE_GL= this looks good.
Thanks for take time for the review, Dmitry.
A commit references this bug: Author: cpm Date: Wed Aug 17 00:45:18 UTC 2016 New revision: 420312 URL: https://svnweb.freebsd.org/changeset/ports/420312 Log: New port: games/iortcw Game engine for Return to Castle Wolfenstein Return to Castle Wolfenstein is a military- and occult-themed first-person shooter game in a Second World War setting, originally released in 2001. It is a sequel to Wolfenstein 3D. This port contains the iortcw game engines for the single-player campaign and multiplayer, based on ioquake3 and the GPL source releases of RtCW. Return to Castle Wolfenstein requires non-distributable game data files, which you have to install manually (see pkg-message). WWW: https://github.com/iortcw/iortcw/ PR: 211456 Submitted by: Tobias Kortkamp <t@tobik.me> Reviewed by: amdmi3 (mentor) Approved by: amdmi3 (mentor) Changes: head/games/Makefile head/games/iortcw/ head/games/iortcw/Makefile head/games/iortcw/distinfo head/games/iortcw/files/ head/games/iortcw/files/Makefile head/games/iortcw/files/iowolfded.in head/games/iortcw/files/iowolfmp.in head/games/iortcw/files/iowolfsp.in head/games/iortcw/files/patch-MP_code_qcommon_q__platform.h head/games/iortcw/files/patch-SP_code_qcommon_q__platform.h head/games/iortcw/pkg-descr head/games/iortcw/pkg-message head/games/iortcw/pkg-plist
Committed! Thanks to all of you.
nicee