Please bump the version. :) https://github.com/fish-shell/fish-shell/releases/tag/2.3.1
There is somethings wrong with PORTSCOUT, it shows still 2.2.0.
quick and dirty test faiils with: CC src/libpcre2_32_la-pcre2_match_data.lo In file included from src/builtin.cpp:354: ./src/builtin_set_color.cpp:15:10: fatal error: 'ncurses/curses.h' file not found #include <ncurses/curses.h> ^ 1 error generated.
Created attachment 173473 [details] svn-diff_shell_fish-2.3.1
Created attachment 173474 [details] svn-diff_shell_fish-2.3.1
Your test failed cause of LDFLAGS, CPPFLAGS (I remove -L/... from LDFLAGS, and CPPFLAGS and add localbase). The patch is tested with poudriere with 103amd64, 93amd64, 93i386, 103i386 and 11amd64. Should work.
testbuilds are fine, waiting for maintainer timeout or approval 8-}
Hi, I'm a fish a developer. There is no longer a dependency on iconv. Be aware that the tarball we ship is vendoring pcre2-10.21 which gets statically built in if it isn't found on the system by the configure script, otherwise it'll link the system's dynamically. As I see PCRE2 in the ports tree, I might guess that normally a package maintainer would prefer to use that.
Created attachment 173865 [details] svn-diff_shell_fish-2.3.1_new
Remove iconv. Pcre is included via "src-Makefiles" (Makefile, Makefile.in, Makefile.am).
I still see ${ICONV_LIB} being added as flags during the compile? My suggestion for PCRE2 is that you mark it as a dependency so that it will dynamically link FreeBSD's version of it, which is likely to get updated faster after the next CVE. Are you saying this is doing that somehow? Anyhow, doesn't really matter to me :) I also noticed earlier on the prior patch that the build was failing and unable to complete an install for me if NLS was disabled through make config.
Further, fish has a few runtime dependencies I am not sure are getting installed. It uses Python (2 or 3) for the fish_config tool, and the script which deroff's manpages and parses out program options to generation completions. Also, shell scripts will not work if `bc` is not on the system, as right now the math "builtin" is actually just implemented as a wrapper around bc. It also uses nroff a little bit. These are a part of the base system I assume, however.
Created attachment 173866 [details] build.log
Sorry, but can you find any ICONV_LIB in the build.log?
No, but here: ` LDFLAGS+= -L${LOCALBASE}/lib -pthread ${ICONV_LIB}`. Maybe it expands to nothing without that USE line? but it probably shouldn't really be there.
Comment on attachment 173866 [details] build.log According to this it will sometimes be empty (native iconv) but other times be replaced with something, is why it worried me: https://www.freebsd.org/doc/en/books/porters-handbook/using-iconv.html I had only tried it on 11.0-RC1 which has native iconv.
Created attachment 173867 [details] svn-diff_shell_fish-2.3.1_new
You are right, I overlooked that, removed it-
What about run depends? Can't find anything about on http://fishshell.com/ or github, README's and in the Changelog.
Off the top of my head: * hostname * bc * python2.7 - 3.anything - no special modules * nroff, ul * manpath * tput that has a terminfo database We have a list somewhere though.
https://github.com/fish-shell/fish-shell/blob/master/README.md#runtime-dependencies
Created attachment 173870 [details] svn-diff_shell_fish-2.3.1
Added python:3 Manpath, ul, bc, nroff, hostname are all in the system.
testbuilds are ok, committed, thanks!
A commit references this bug: Author: pi Date: Wed Sep 7 18:53:50 UTC 2016 New revision: 421518 URL: https://svnweb.freebsd.org/changeset/ports/421518 Log: shells/fish: 2.2.0 -> 2.3.1 PR: 211688 Changes: https://github.com/fish-shell/fish-shell/releases/tag/2.3.1 Submitted by: Walter Schwarzenfeld <w.schwarzenfeld@utanet.at> Requested by: Stefan Tatschner <rumpelsepp@sevenbyte.org> Reviewed by: Aaron Gyes <me@aaron.gy> Approved by: freebsd.users@gmail.com (maintainer timeout) Changes: head/shells/fish/Makefile head/shells/fish/distinfo head/shells/fish/pkg-plist