Bug 211700 - databases/lmdb: add soname and cleanup
Summary: databases/lmdb: add soname and cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-09 17:28 UTC by Mathieu Arnold
Modified: 2016-08-09 21:31 UTC (History)
0 users

See Also:
delphij: maintainer-feedback+

Attachments
patch (941 bytes, patch)
2016-08-09 17:28 UTC, Mathieu Arnold 		no flags Details | Diff
patch-cleanup (1.74 KB, patch)
2016-08-09 17:30 UTC, Mathieu Arnold 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2016-08-09 17:28:32 UTC 
Created attachment 173468 [details]
patch

Using soname allows pkg(8) to register the library, and it helps on upgrades.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2016-08-09 17:30:58 UTC 
Created attachment 173469 [details]
patch-cleanup

Let's add a second patch to clean things up a bit:

1) use WRKSRC_SUBDIR
2) use MAKE_ARGS instead of MAKE_ENV so the patch can be simplified.
Comment 2 Xin LI freebsd_committer freebsd_triage 2016-08-09 20:37:10 UTC 
Looks good to me, please go ahead and commit.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-08-09 21:28:53 UTC 
A commit references this bug:

Author: mat
Date: Tue Aug  9 21:28:45 UTC 2016
New revision: 419973
URL: https://svnweb.freebsd.org/changeset/ports/419973

Log:
  Add soname and cleanup

  Using soname allows pkg(8) to register the library, and it helps on
  upgrades.
  Use WRKSRC_SUBDIR
  Use MAKE_ARGS instead of MAKE_ENV so the patch can be simplified.

  PR:		211700
  Submitted by:	mat
  Approved by:	delphij (maintainer)
  Sponsored by:	Absolight

Changes:
  head/databases/lmdb/Makefile
  head/databases/lmdb/files/patch-Makefile