Bug 211839 - lang/harbour: make database options work and other fixes
Summary: lang/harbour: make database options work and other fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-14 15:38 UTC by Pawel Pekala
Modified: 2016-08-23 20:43 UTC (History)
1 user (show)

See Also:
m.tsatsenko: maintainer-feedback+


Attachments
fix db options (17.32 KB, patch)
2016-08-14 15:38 UTC, Pawel Pekala
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pekala freebsd_committer freebsd_triage 2016-08-14 15:38:49 UTC
Created attachment 173668 [details]
fix db options

- Make FIREBIRD, MYSQL, PGSQL, SQLITE actually work. By providing correct include directories via MAKE_ENV makes this ports detect installed client db libraries and produce include files and static libraries for each supported database.
- Respect CFLAGS and LDFLAGS during build, disable optimized compilation flags via HB_BUILD_OPTIM=no - this removes -O3 flag from CFLAGS
- Convert to options helpers, USES=ssl
- Use options substitutions for optional database support files
- Sort pkg-plist
Comment 1 m.tsatsenko 2016-08-22 21:30:10 UTC
Looks fine for me.
Thanks for your work!
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-08-23 20:43:19 UTC
A commit references this bug:

Author: pawel
Date: Tue Aug 23 20:42:23 UTC 2016
New revision: 420746
URL: https://svnweb.freebsd.org/changeset/ports/420746

Log:
  - Make FIREBIRD, MYSQL, PGSQL, SQLITE actually work. By providing correct
    include directories via MAKE_ENV makes this ports detect installed client
    db libraries and produce include files and static libraries for each
    supported database.
  - Respect CFLAGS and LDFLAGS during build, disable optimized compilation
    flags via HB_BUILD_OPTIM=no - this removes -O3 flag from CFLAGS
  - Convert to options helpers, USES=ssl
  - Use options substitutions for optional database support files
  - Sort pkg-plist

  PR:		211839
  Submitted by:	myself
  Approved by:	maintainer

Changes:
  head/lang/harbour/Makefile
  head/lang/harbour/pkg-plist