Bug 212023 - multimedia/ffmpeg: Add SNDIO option
Summary: multimedia/ffmpeg: Add SNDIO option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: easy, feature, needs-qa
Depends on:
Blocks:
 
Reported: 2016-08-21 07:06 UTC by Tobias Kortkamp
Modified: 2016-12-04 10:23 UTC (History)
2 users (show)

See Also:
riggs: maintainer-feedback+

Attachments
ffmpeg.diff (1.13 KB, patch)
2016-08-21 07:06 UTC, Tobias Kortkamp 		no flags Details | Diff
ffmpeg.diff (1.20 KB, patch)
2016-08-21 10:12 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (multimedia)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2016-08-21 07:06:27 UTC 
Created attachment 173903 [details]
ffmpeg.diff

This adds input and output device support for audio/sndio to the port.

portlint ok, poudriere testport 10.2/amd64 ok
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-08-21 09:50:31 UTC 
Thanks Tobias.

./configure arguments in particular should normally be exclusively set in both ON/OFF cases to reduce the incidence of implicit feature/library detection in non-clean (user installations unlike poudriere) environments.

If there are corresponding --ENable-{in,out}dev arguments, could you please update the patch to add them
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2016-08-21 10:12:08 UTC 
Created attachment 173907 [details]
ffmpeg.diff

(In reply to Kubilay Kocak from comment #1)
Thanks, I've added them.

The port does this too with ALSA and JACK.  I believe I just copied the ALSA option originally.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-12-04 10:15:11 UTC 
A commit references this bug:

Author: riggs
Date: Sun Dec  4 10:14:46 UTC 2016
New revision: 427763
URL: https://svnweb.freebsd.org/changeset/ports/427763

Log:
  Add non-default OPTION for SNDIO

  PR:		212023
  Submitted by:	t@tobik.me

Changes:
  head/multimedia/ffmpeg/Makefile