Bug 212037 - comms/rxtx unneeded dependency on Linux emu
Summary: comms/rxtx unneeded dependency on Linux emu
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-22 03:39 UTC by howard0su
Modified: 2016-12-25 13:38 UTC (History)
1 user (show)

See Also:
amdmi3: maintainer-feedback+


Attachments
Portlint output (2.81 KB, text/plain)
2016-12-24 22:38 UTC, James Elstone
james: maintainer-approval+
Details
svn diff file for "Makefile" (542 bytes, patch)
2016-12-24 22:46 UTC, James Elstone
james: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description howard0su 2016-08-22 03:39:18 UTC
Index: comms/rxtx/Makefile
===================================================================
--- comms/rxtx/Makefile	(revision 420316)
+++ comms/rxtx/Makefile	(working copy)
@@ -14,7 +14,6 @@
 COMMENT=	Native interface to serial ports in Java
 
 USES=		gmake libtool zip
-USE_LINUX=	c6
 
 USE_JAVA=	yes
 JAVA_VERSION=	1.6+

I tested the code without this flag also uninstall all linux packages, arduino still works well. The change will avoid install Linux package when not necessary.
Comment 1 James Elstone 2016-09-04 23:30:42 UTC
Hi Howard,

I believe from memory that there is a dependency on certain components for all of RxTx functions to operate as expected.

Give me a few days to have a look into this in detail, and I'll post my findings back here.

Is this causing a functional issue for you?

Kind regards,

James
Comment 2 howard0su 2016-09-05 05:27:05 UTC
(In reply to JamesElstone from comment #1)

I would love to know the details of issues and I can fix. There are lots of places in the code of rxtx use "#if FREEBSD" to support FreeBSD already. it doesn't make sense that enable Linux while building rxtx for FreeBSD. It doesn't sound correct to me.

Based on my testing, it works fine with Arduino.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2016-09-21 13:48:30 UTC
> Give me a few days to have a look into this in detail, and I'll post my findings back here.

Quite a few days have passed. Any news?
Comment 4 James Elstone 2016-09-22 07:22:29 UTC
Hi Howard,

Sorry for my tardy response; I have been on the receiving end of a car accident.

Have had a look at the code base today, and it maybe possible to reduce this requirement, and fully understand your point.  linux-c6 was added in to meet a required missing dependancy last year.

I am also mindful that while it compiles, I want to make sure it functionally works in all known scenarios, as right now it is working.

I will have access to a bare metal system this weekend to functionally check that 32-bit and 64-bit systems are OK with the ommission.  RxTx is used beyond those defined in the ports tree and don't want to interupt functionality for the existing Arduino userbase.

I will comment further at the weekend; Was there specific areas of the java code that you thought needed attention beyond the update in the Makefile?

Kr,

James
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2016-10-05 18:56:04 UTC
Ping again
Comment 6 James Elstone 2016-10-31 21:41:15 UTC
Right, oddly cannot find reference for any Linux c6 component.  Want to make very sure that any changes doesn't fluff it up, but have a very distinct memory the c6 dependancy had to be added to handle an unfullfilled reference somewhere!!

To make very sure, am going to spin up four x11 installations from bare metal on 10.3-STABLE and 11.0-STABLE for both i386 and amd64 to double check, all is OK, and it is not my desktop machine causing my confusion...

Currently X11 installing on 11.0-STABLE on two nodes, and 10.3-STABLE installing on to bear metal for another two.

Will try to commit time to this over the comming week.
Comment 7 Dmitry Marakasov freebsd_committer freebsd_triage 2016-12-24 16:50:10 UTC
Months have passed. Ping?
Comment 8 James Elstone 2016-12-24 22:36:16 UTC
Confirmed Linux linkage is only in JAR file provided initially with Arduino IDE v1.0.6, of which are removed during installation of the "devel/arduino" port and linked to the ones herein.  Dependencies are correct.

Portlint reports 13 warnings of regarding generation of patch files, and no errors.  The port patches without error as intended.

Poudriere log attached for reference.

Diff file attached for committal when someone with a commit bit has time please.

Tested with Arduino / Genuino I have here using 11.0-RELEASE-p5 (r310098) on ports tree (r428598).  Upload works fine.

Once added permissions to non-root user to dialer group behaved as expected.  Information about dialer group requirements contained in Arduino pkg_info message.

(P.S. I had forgotten how much duration it takes to get a X window system running from cold metal, and thus finding the time to support this was a challenge).
Comment 9 James Elstone 2016-12-24 22:38:34 UTC
Created attachment 178252 [details]
Portlint output
Comment 10 James Elstone 2016-12-24 22:46:09 UTC
Created attachment 178253 [details]
svn diff file for "Makefile"

This file is to be committed when possible please.
Comment 11 James Elstone 2016-12-24 23:21:26 UTC
(Re-running Poudriere due to human error in copying the log from my build system; will attach ASAP).
Comment 12 commit-hook freebsd_committer freebsd_triage 2016-12-25 13:38:17 UTC
A commit references this bug:

Author: amdmi3
Date: Sun Dec 25 13:37:17 UTC 2016
New revision: 429423
URL: https://svnweb.freebsd.org/changeset/ports/429423

Log:
  - Remove unneeded depend on linux emulation

  PR:		212037
  Submitted by:	james@elstone.net (maintainer)
  Reported by:	howard0su@gmail.com

Changes:
  head/comms/rxtx/Makefile