Bug 212046 - net-p2p/bitmessage: Update to 0.6.1
Summary: net-p2p/bitmessage: Update to 0.6.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on: 213717
Blocks:
  Show dependency tree / graph
 
Reported: 2016-08-22 10:33 UTC by Yuri Victorovich
Modified: 2016-11-03 04:09 UTC (History)
0 users

See Also:

Attachments
patch (4.62 KB, patch)
2016-08-22 10:33 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
patch (6.71 KB, patch)
2016-09-06 20:14 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
patch (7.15 KB, patch)
2016-09-21 17:32 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2016-08-22 10:33:39 UTC 
Created attachment 173933 [details]
patch

Deleted patch under files/ is applied upstream.
Passes poudriere on 10.3 amd64.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-08-23 11:00:00 UTC 
Extended shebang check shows problems:

====> Running Q/A tests (stage-qa)
Error: 'python' is an invalid shebang you need USES=shebangfix for 'share/pybitmessage/depends.py'
Error: '/usr/bin/python2.7' is an invalid shebang you need USES=shebangfix for 'share/pybitmessage/bitmessagemain.py'
Warning: 'share/pybitmessage/bitmsghash/bitmsghash.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
*** Error code 1
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2016-08-23 17:05:28 UTC 
I am puzzled by bitmsghash.so not being stripped, because it is stripped by this command:
> @${STRIP_CMD} ${STAGEDIR}${PREFIX}/share/pybitmessage/bitmsghash/bitmsghash.so
I have it stripped.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2016-09-06 19:52:59 UTC 
(In reply to yuri from comment #2)
> I am puzzled by bitmsghash.so not being stripped, because it is stripped by
> this command:
> > @${STRIP_CMD} ${STAGEDIR}${PREFIX}/share/pybitmessage/bitmsghash/bitmsghash.so
> I have it stripped.

Sorry, artifact from conversion to options helpers. Shebangs still need to be fixed.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2016-09-06 20:14:24 UTC 
Created attachment 174435 [details]
patch

Patched shebangs. Submitted the PR to the upstream.
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2016-09-21 15:43:40 UTC 
- Something is broken with Makefile patching:

  echo 'exec /usr/local/bin//usr/local/bin/python2.7.7 bitmessagemain.py' >> ${DESTDIR}${PREFIX}/bin/${APP}

You should not hardcode python path at all, replace it with PYTHON_CMD contents.

- Needs REINPLACE_ARGS= -i ''  to not stage .bak files:

====> Running Q/A tests (stage-qa)
Error: 'python' is an invalid shebang you need USES=shebangfix for 'share/pybitmessage/depends.py.bak'
Error: '/usr/bin/python2.7' is an invalid shebang you need USES=shebangfix for 'share/pybitmessage/bitmessagemain.py.bak'
*** Error code 1

- Preferrably, convert conditions to option-dependent targets (do-build-NATIVE_POW-on, post-install-NATIVE_POW-on)

- Patch needs to be regenerated after r421975
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2016-09-21 17:32:44 UTC 
Created attachment 175037 [details]
patch
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2016-10-02 06:39:51 UTC 
Ping.

This needs to be committed and closed.
Comment 8 Dmitry Marakasov freebsd_committer freebsd_triage 2016-10-06 15:52:04 UTC 
Sorry for delay.
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-10-06 15:52:20 UTC 
A commit references this bug:

Author: amdmi3
Date: Thu Oct  6 15:51:59 UTC 2016
New revision: 423411
URL: https://svnweb.freebsd.org/changeset/ports/423411

Log:
  - Update to 0.6.1

  PR:		212046
  Submitted by:	yuri@rawbw.com (maintainer)

Changes:
  head/net-p2p/bitmessage/Makefile
  head/net-p2p/bitmessage/distinfo
  head/net-p2p/bitmessage/files/patch-Makefile
  head/net-p2p/bitmessage/files/patch-src_bitmsghash_Makefile
  head/net-p2p/bitmessage/files/patch-src_bitmsghash_bitmsghash.cpp
  head/net-p2p/bitmessage/pkg-plist