Bug 212064 - Packaging of mail/postfix-policyd-spf-python fails due to out of date plist with Python 3.5
Summary: Packaging of mail/postfix-policyd-spf-python fails due to out of date plist w...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-22 20:46 UTC by Joseph Mulloy
Modified: 2016-10-09 09:07 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (me)

Attachments
Fix packaging with both python branches (995 bytes, patch)
2016-09-24 07:55 UTC, Ruslan Makhmatkhanov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Mulloy 2016-08-22 20:46:19 UTC 
I'm compiling this port via poudriere, with the Python version set to 3.5. The packaging step fails because the plist specifies .pyc and .pyo files without ".cpython-25" in front of the .py[co]. Either the plist needs to be adjusted or the port needs to switch to using autoplist. I'm not sure how this works on Python 2.x, but this port doesn't work on Python 2.x any more anyways.

Current PLIST:
%%PYTHON_SITELIBDIR%%/policydspfsupp.py
%%PYTHON_SITELIBDIR%%/policydspfsupp.pyo
%%PYTHON_SITELIBDIR%%/policydspfsupp.pyc
%%PYTHON_SITELIBDIR%%/policydspfuser.py
%%PYTHON_SITELIBDIR%%/policydspfuser.pyo
%%PYTHON_SITELIBDIR%%/policydspfuser.pyc

Proposed updated PLIST:
%%PYTHON_SITELIBDIR%%/policydspfsupp.cpython-%%PYVER%%.py
%%PYTHON_SITELIBDIR%%/policydspfsupp.cpython-%%PYVER%%.pyo
%%PYTHON_SITELIBDIR%%/policydspfsupp.cpython-%%PYVER%%.pyc
%%PYTHON_SITELIBDIR%%/policydspfuser.cpython-%%PYVER%%.py
%%PYTHON_SITELIBDIR%%/policydspfuser.cpython-%%PYVER%%.pyo
%%PYTHON_SITELIBDIR%%/policydspfuser.cpython-%%PYVER%%.pyc
Comment 1 Walter Schwarzenfeld 2016-08-22 22:24:47 UTC 
With python2.7 the old pkg-plist is right.
Comment 2 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-09-24 07:55:31 UTC 
Created attachment 175118 [details]
Fix packaging with both python branches

Hi, would you approve this patch? It is fixing packaging both with python2 and python3 set as default.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-10-09 09:07:20 UTC 
A commit references this bug:

Author: rm
Date: Sun Oct  9 09:06:28 UTC 2016
New revision: 423581
URL: https://svnweb.freebsd.org/changeset/ports/423581

Log:
  mail/postfix-policyd-spf-python: fix packaging with python3

  Make the port use autoplist feature to let it package both with
  python2 and python3.

  PR:		212064
  Reported by:	Joseph Mulloy <freebsd-bugs@joe.mulloy.me>
  Approved by:	maintainer timeout (14 days)

Changes:
  head/mail/postfix-policyd-spf-python/Makefile
  head/mail/postfix-policyd-spf-python/pkg-plist
Comment 4 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-10-09 09:07:42 UTC 
Fixed, thanks for reporting.