Bug 212233 - [patch] editors/neovim: update to 0.1.5
Summary: [patch] editors/neovim: update to 0.1.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-08-29 08:33 UTC by Oleh Hushchenkov
Modified: 2016-10-05 18:44 UTC (History)
1 user (show)

See Also:

Attachments
patch (6.33 KB, patch)
2016-08-29 08:33 UTC, Oleh Hushchenkov 		no flags Details | Diff
patch v2 (10.40 KB, patch)
2016-08-29 09:56 UTC, Oleh Hushchenkov 		no flags Details | Diff
patch v3 (10.50 KB, patch)
2016-08-29 10:31 UTC, Oleh Hushchenkov 		no flags Details | Diff
updated patch (10.48 KB, patch)
2016-09-14 12:51 UTC, Oleh Hushchenkov 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleh Hushchenkov 2016-08-29 08:33:06 UTC 
Created attachment 174174 [details]
patch

Update neovim to 0.1.5
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-08-29 09:37:30 UTC 
- Fails to patch:

===>  Applying FreeBSD patches for neovim-0.1.5
Ignoring previously applied (or reversed) patch.
2 out of 2 hunks ignored--saving rejects to config/CMakeLists.txt.rej
=> Patch patch-config__CMakeLists.txt failed to apply cleanly.
=> Patch(es) patch-CMakeLists.txt applied cleanly.
*** Error code 1

- This does not seem to be incorrect:
foreach(CURRENT_LUA_PRG luajit lua5.1 lua5.2 lua)

The port should _only_ use lua version listed in depends. Since you don't specify lua version in USES=lua, depends, you must substitute ${LUA_VER} here.

Also, does it really require lua while using luajit? luajit is complete drop-in replacement for lua as far as I know, and these should not be mixed.
Comment 2 Oleh Hushchenkov 2016-08-29 09:56:23 UTC 
Created attachment 174177 [details]
patch v2

Sorry, forgot delete obsolete patches.
Comment 3 Oleh Hushchenkov 2016-08-29 10:31:59 UTC 
Created attachment 174178 [details]
patch v3

Fast fix Lua usage.
Comment 4 Oleh Hushchenkov 2016-09-14 12:51:43 UTC 
Created attachment 174778 [details]
updated patch
Comment 5 Oleh Hushchenkov 2016-09-14 13:03:28 UTC 
Fix CMakeLists.txt to detect only luajit. Lua still needed for build, because lpeg is only available for lua.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-10-05 18:44:14 UTC 
A commit references this bug:

Author: amdmi3
Date: Wed Oct  5 18:43:46 UTC 2016
New revision: 423366
URL: https://svnweb.freebsd.org/changeset/ports/423366

Log:
  - Update to 1.15

  PR:		212233
  Submitted by:	gor@clogic.com.ua (maintainer)

Changes:
  head/editors/neovim/Makefile
  head/editors/neovim/distinfo
  head/editors/neovim/files/patch-CMakeLists.txt
  head/editors/neovim/files/patch-config__CMakeLists.txt
  head/editors/neovim/files/patch-config__config.h.in
  head/editors/neovim/files/patch-src__nvim__shada.c
  head/editors/neovim/files/patch-src_nvim_event_pty__process.c
  head/editors/neovim/pkg-plist