Bug 212340 - security/rndpassw: Update to 0.2.2
Summary: security/rndpassw: Update to 0.2.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-02 20:12 UTC by Andrew Romanenko
Modified: 2016-11-12 16:28 UTC (History)
0 users

See Also:

Attachments
rndpassw.shar (1.37 KB, application/x-shar)
2016-09-02 20:12 UTC, Andrew Romanenko 		no flags Details
rndpassw.patch (from svn diff) (1.53 KB, patch)
2016-09-08 20:41 UTC, Andrew Romanenko 		no flags Details | Diff
patch (4.59 KB, patch)
2016-09-10 18:06 UTC, Andrew Romanenko 		no flags Details | Diff
fix (4.59 KB, patch)
2016-09-18 16:19 UTC, Andrew Romanenko 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Romanenko 2016-09-02 20:12:16 UTC 
Created attachment 174321 [details]
rndpassw.shar
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-09-05 15:40:58 UTC 
- Please submit updates as patches (`svn diff` output)
- GH_PROJECTS is not needed. It's actually spelled `GH_PROJECT` and it defaults to ${PORTNAME} so doesn't need to be redefined in this case
- Please do not force CMAKE_BUILD_TYPE and do not override system compiler flags (by adding -O2)
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2016-09-05 15:48:21 UTC 
- Also distinfo lacks required TIMESTAMP field (generated with outdated version of portstree?)
Comment 3 Andrew Romanenko 2016-09-08 20:41:34 UTC 
Created attachment 174542 [details]
rndpassw.patch (from svn diff)
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2016-09-10 13:13:36 UTC 
Please test your ports with poudriere before submission.

===>  Applying FreeBSD patches for rndpassw-0.2.2
No file to patch.  Skipping...
2 out of 2 hunks ignored--saving rejects to Makefile.rej
=> Patch patch-Makefile failed to apply cleanly.
Comment 5 Andrew Romanenko 2016-09-10 18:06:53 UTC 
Created attachment 174625 [details]
patch
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2016-09-10 22:12:14 UTC 
Again, please test your ports before submission. This fails on 9.x:

cd /wrkdirs/usr/ports/security/rndpassw/work/.build/src && /usr/local/libexec/ccache/cc   -I/wrkdirs/usr/ports/security/rndpassw/work/rndpassw-0.2.2/src -O2 -pipe -fstack-protector -fno-strict-aliasing -fPIC -DPIC -std=c90 -Wall -Werror -Wmissing-prototypes -DNDEBUG -o CMakeFiles/rndpassw.dir/rndpassw.c.o   -c /wrkdirs/usr/ports/security/rndpassw/work/rndpassw-0.2.2/src/rndpassw.c
cc1: error: unrecognized command line option "-std=c90"
*** [src/CMakeFiles/rndpassw.dir/rndpassw.c.o] Error code 1
Comment 7 Andrew Romanenko 2016-09-18 16:19:20 UTC 
Created attachment 174921 [details]
fix
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-11-12 16:28:18 UTC 
A commit references this bug:

Author: amdmi3
Date: Sat Nov 12 16:28:09 UTC 2016
New revision: 425966
URL: https://svnweb.freebsd.org/changeset/ports/425966

Log:
  - Update to 0.2.2
  - Add LICENSE_FILE

  PR:		212340
  Submitted by:	melanhit@gmail.com (maintainer)

Changes:
  head/security/rndpassw/Makefile
  head/security/rndpassw/distinfo
  head/security/rndpassw/files/
  head/security/rndpassw/pkg-descr