Bug 212367 - [patch] security/revelation fails to check long-enough password
Summary: [patch] security/revelation fails to check long-enough password
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-04 09:31 UTC by Tomoaki AOKI
Modified: 2018-10-09 08:47 UTC (History)
2 users (show)

See Also:

Attachments
Patch for Makefile (367 bytes, patch)
2016-09-04 09:35 UTC, Tomoaki AOKI 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomoaki AOKI 2016-09-04 09:31:35 UTC 
security/revelation fails to check long-enough (9 characters or longer) password via security/py-cracklib and security/cracklib.

This is because security/revelation assumes old password database name.

Chasing database name change at r408137 of security/cracklib (pw_dict to cracklib-words) fixes this.
Comment 1 Tomoaki AOKI 2016-09-04 09:35:27 UTC 
Created attachment 174365 [details]
Patch for Makefile

Attached patch works for me.
Apply it on the top of security/revelation.

By the way, "Add attachment" at submitting form didn't have "patch" checkbox.
So I uploaded it separately.
Comment 2 Tomoaki AOKI 2016-09-04 09:42:45 UTC 
Forgot to show error message shown.
As I'm running with LANG=ja_JP.UTF-8, Japanese error message is shown.
It (last "OSError" line) means "No such file or directory".

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/revelation/ui.py", line 1019, in __cb_check_password
    util.check_password(password)
  File "/usr/local/lib/python2.7/site-packages/revelation/util.py", line 97, in check_password
    cracklib.FascistCheck(password, "/usr/local/libdata/cracklib/pw_dict")
OSError: [Errno 2] そのようなファイルまたはディレクトリはありません: '/usr/local/libdata/cracklib/pw_dict.pwd'
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-10-09 08:46:02 UTC 
A commit references this bug:

Author: tobik
Date: Tue Oct  9 08:45:50 UTC 2018
New revision: 481611
URL: https://svnweb.freebsd.org/changeset/ports/481611

Log:
  security/revelation: Chase dictionary rename from r408137

  r408137 of security/cracklib renamed pw_dict to cracklib-words and
  revelation now fails to check passwords with 9 characters or more:

  Traceback (most recent call last):
    File "/usr/local/lib/python2.7/site-packages/revelation/dialog.py", line 1183, in __cb_changed
      util.check_password(password)
    File "/usr/local/lib/python2.7/site-packages/revelation/util.py", line 97, in check_password
      cracklib.FascistCheck(password, "/usr/local/libdata/cracklib/pw_dict")
  OSError: [Errno 2] No such file or directory: '/usr/local/libdata/cracklib/pw_dict.pwd'

  PR:		212367
  Submitted by:	Tomoaki AOKI <junchoon@dec.sakura.ne.jp>

Changes:
  head/security/revelation/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-10-09 08:47:06 UTC 
A commit references this bug:

Author: tobik
Date: Tue Oct  9 08:46:29 UTC 2018
New revision: 481612
URL: https://svnweb.freebsd.org/changeset/ports/481612

Log:
  MFH: r481611

  security/revelation: Chase dictionary rename from r408137

  r408137 of security/cracklib renamed pw_dict to cracklib-words and
  revelation now fails to check passwords with 9 characters or more:

  Traceback (most recent call last):
    File "/usr/local/lib/python2.7/site-packages/revelation/dialog.py", line 1183, in __cb_changed
      util.check_password(password)
    File "/usr/local/lib/python2.7/site-packages/revelation/util.py", line 97, in check_password
      cracklib.FascistCheck(password, "/usr/local/libdata/cracklib/pw_dict")
  OSError: [Errno 2] No such file or directory: '/usr/local/libdata/cracklib/pw_dict.pwd'

  PR:		212367
  Submitted by:	Tomoaki AOKI <junchoon@dec.sakura.ne.jp>

  Approved by:	ports-secteam runtime fix blanket

Changes:
_U  branches/2018Q4/
  branches/2018Q4/security/revelation/Makefile
Comment 5 Tobias Kortkamp freebsd_committer freebsd_triage 2018-10-09 08:47:24 UTC 
Committed. Thank you!

Apologies that it took 2 years to get this trivial fix in.