Bug 212377 - devel/binutils RELRO description is not descriptive
Summary: devel/binutils RELRO description is not descriptive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-04 23:06 UTC by Warren Block
Modified: 2020-03-24 16:46 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bapt)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Warren Block freebsd_committer freebsd_triage 2016-09-04 23:06:25 UTC 
The new RELRO option is described as "enable -z relro in ELF linker by default".

This is not useful to the reader.  The name of the option implies that it enables that feature.  What the user installing a port needs to know is what effect that option will have.

For example: "Enable Relocation Read-Only memory corruption mitigation by default."
Comment 1 Ed Maste freebsd_committer freebsd_triage 2017-12-18 14:15:07 UTC 
I think it's important that the option description *also* include the string relro. A user interested in mitigations will immediately know what a relro option does, while the more verbose description takes more thought/consideration.

E.g. something like
Enable relocation memory corruption mitigation (-z relro) by default.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-03-24 16:46:39 UTC 
A commit references this bug:

Author: bapt
Date: Tue Mar 24 16:36:26 UTC 2020
New revision: 529050
URL: https://svnweb.freebsd.org/changeset/ports/529050

Log:
  Improve RELRO description

  PR:		212377
  Submitted by:	emaste
  Reported by:	wblock

Changes:
  head/devel/binutils/Makefile