Bug 212398 - cad/gmsh: Upgrade to version 2.13.2 and improve
Summary: cad/gmsh: Upgrade to version 2.13.2 and improve
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL: https://reviews.freebsd.org/D7703
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-09-06 00:51 UTC by Joseph Mingrone
Modified: 2016-09-29 19:16 UTC (History)
2 users (show)

See Also:


Attachments
svn diff to upgrade and improve cad/gmsh (12.12 KB, patch)
2016-09-06 00:51 UTC, Joseph Mingrone
jrm: maintainer-approval+
Details | Diff
second svn diff to add missing patch and suggested changes (22.74 KB, patch)
2016-09-10 15:21 UTC, Joseph Mingrone
jrm: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Mingrone freebsd_committer freebsd_triage 2016-09-06 00:51:12 UTC
Created attachment 174400 [details]
svn diff to upgrade and improve cad/gmsh

- Upgrade to version 2.13.2
- Update MASTER_SITES to only include new gmsh site
- Remove no-longer-needed definitions of DISTFILES, EXTRACT_ONLY, and WRKSRC
- The licensing situation is simpler now. Gmsh itself is released under
  GPLv3+ [1], TetGen under AGPLv3+ [2], and METIS under an APACHE2
  license [3]. For now, TAUCS is the only component released under a
  non-standard license [4].
- Fix misnamed KNOB in KNOB_DESC=, so make config shows descriptions
- Fix errors/warnings reported by portlint and poudriere testport
  - add missing entries to LIB_DEPENDS=
  - add blaslapack to USES=
  - change USE_GL=yes to USE_GL=gl glu
  - add USE_XORG=x11 xext xfixes xft
- Redo patches with make makepatch
- Remove MAKE_JOBS_UNSAFE=yes (no build errors and the build time went from 30+
  minutes to under 13)
- Match upstream by turning on TAUCS by default
- Modernize option handling
- Add patch to fix linking error when the TAUCS knob is turned on
- Update pkg-plist

porlint: looks fine
testport: OK (poudriere: 9.3-RELEASE, i386, default options) [5]
testport: OK (poudriere: 9.3-RELEASE, amd64, default options) [6]
testport: OK (poudriere: 10.3-RELEASE, i386, default options) [7]
testport: OK (poudriere: 10.3-RELEASE, amd64, default options) [8]
testport: OK (poudriere: 11.0-RC2, i386, default options) [9]
testport: OK (poudriere: 11.0-RC2, amd64, default options) [10]

[1] http://gmsh.info/#Licensing
[2] http://wias-berlin.de/software/tetgen/1.5/FAQ-license.html
[3] http://glaros.dtc.umn.edu/gkhome/metis/metis/faq?q=metis/metis/faq#cite
[4] http://www.tau.ac.il/~stoledo/taucs/

[5]  http://pkg.awarnach.mathstat.dal.ca/data/9i386-default/2016-09-05_17h41m03s/logs/gmsh-2.13.2.log
[6]  http://pkg.awarnach.mathstat.dal.ca/data/9amd64-default/2016-09-05_17h41m09s/logs/gmsh-2.13.2.log
[7]  http://pkg.awarnach.mathstat.dal.ca/data/10i386-default/2016-09-05_17h41m21s/logs/gmsh-2.13.2.log
[8]  http://pkg.awarnach.mathstat.dal.ca/data/10amd64-default/2016-09-05_17h41m28s/logs/gmsh-2.13.2.log
[9]  http://pkg.awarnach.mathstat.dal.ca/data/11i386-default/2016-09-05_17h41m35s/logs/gmsh-2.13.2.log
[10] http://pkg.awarnach.mathstat.dal.ca/data/10amd64-default/2016-09-05_17h41m28s/logs/gmsh-2.13.2.log
Comment 1 Joseph Mingrone freebsd_committer freebsd_triage 2016-09-10 15:21:31 UTC
Created attachment 174622 [details]
second svn diff to add missing patch and suggested changes

1. This second diff adds a patch, accidentally missing from the first diff, which fixes a linking error.
2. Add amdmi3@'s recommendations
  - cosmetic changes
  - modernize cmake option handling
  - remove port options for on-by-default bundled options
3. Match upstream defaults

porlint: looks fine
testport: OK (poudriere: 9.3-RELEASE, i386, default options)   [1]
testport: OK (poudriere: 9.3-RELEASE, amd64, default options)  [2]
testport: OK (poudriere: 10.3-RELEASE, i386, default options)  [3]
testport: OK (poudriere: 10.3-RELEASE, amd64, default options) [4]
testport: OK (poudriere: 11.0-RC2, i386, default options)      [5]
testport: OK (poudriere: 11.0-RC2, amd64, default options)     [6]

[1]  http://pkg.awarnach.mathstat.dal.ca/data/9i386-default/2016-09-10_11h34m23s/logs/gmsh-2.13.2.log
[2]  http://pkg.awarnach.mathstat.dal.ca/data/9amd64-default/2016-09-10_11h34m25s/logs/gmsh-2.13.2.log
[3]  http://pkg.awarnach.mathstat.dal.ca/data/10i386-default/2016-09-10_11h34m27s/logs/gmsh-2.13.2.log
[4]  http://pkg.awarnach.mathstat.dal.ca/data/10amd64-default/2016-09-10_11h34m30s/logs/gmsh-2.13.2.log
[5]  http://pkg.awarnach.mathstat.dal.ca/data/11i386-default/2016-09-10_11h34m33s/logs/gmsh-2.13.2.log
[6]  http://pkg.awarnach.mathstat.dal.ca/data/11amd64-default/2016-09-10_11h34m40s/logs/gmsh-2.13.2.log
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-09-29 19:16:24 UTC
A commit references this bug:

Author: jrm
Date: Thu Sep 29 19:15:35 UTC 2016
New revision: 422939
URL: https://svnweb.freebsd.org/changeset/ports/422939

Log:
  Update cad/gmsh to 2.13.2; fix knob issue; other changes

  - Upgrade to version 2.13.2
  - Update MASTER_SITES to only include new gmsh site
  - Remove no-longer-needed definitions of DISTFILES, EXTRACT_ONLY, and WRKSRC
  - The licensing situation is simpler now:  Gmsh itself is released under
    GPLv3+ [1], TetGen under AGPLv3+ [2], and METIS under an APACHE2 license [3]
    For now, TAUCS is the only component released under a non-standard license [4]
  - Fix misnamed KNOB in KNOB_DESC=, so `make config` shows descriptions
  - Fix errors/warnings reported by portlint and poudriere testport
    - Add missing entries to LIB_DEPENDS=
    - Add blaslapack to USES=
    - Change USE_GL=yes to USE_GL=gl glu
    - Add USE_XORG=x11 xext xfixes xft
    - Redo patches with make makepatch
  - Remove MAKE_JOBS_UNSAFE=yes
  - Remove options for bundled software
  - Update default options
  - Add patch to fix TAUCS linking error
  - Modernize option handling
  - Mark broken on FreeBSD 12 i386 due to clang bug:
    (https://llvm.org/bugs/show_bug.cgi?id=21903)
  - Remove unnecessary TAUCS_LIB_DEPENDS=libtaucs.so:math/taucs to prevent
    problems with french/aster
    - cad/gmsh includes a bundled taucs, so
      TAUCS_LIB_DEPENDS=libtaucs.so:math/taucs can be removed
    - math/taucs pulls in math/metis4, but french/aster, which depends on
      cad/gmsh, pulls in conflicting math/taucs-edf
  - Update pkg-plist

  [1]  http://gmsh.info/#Licensing
  [2]  http://wias-berlin.de/software/tetgen/1.5/FAQ-license.html
  [3]  http://glaros.dtc.umn.edu/gkhome/metis/metis/faq?q=metis/metis/faq#cite
  [4]  http://www.tau.ac.il/~stoledo/taucs/

  PR:		212398
  Reviewed by:	swills (mentor) AMDmi3 (mentor)
  Approved by:	swills (mentor)
  Differential Revision:	https://reviews.freebsd.org/D7703

Changes:
  head/cad/gmsh/Makefile
  head/cad/gmsh/distinfo
  head/cad/gmsh/files/patch-Fltk-Main.cpp
  head/cad/gmsh/files/patch-Fltk_Main.cpp
  head/cad/gmsh/files/patch-Geo_CustomContainer.h
  head/cad/gmsh/files/patch-Geo__CustomContainer.h
  head/cad/gmsh/files/patch-contrib_taucs_config_taucs__config__build.h
  head/cad/gmsh/pkg-descr
  head/cad/gmsh/pkg-plist