Bug 212462 - lang/spidermonkey185: fails to build on armv6
Summary: lang/spidermonkey185: fails to build on armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Koop Mast
URL: http://beefy8.nyi.freebsd.org/data/he...
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-09-07 17:51 UTC by Mikael Urankar
Modified: 2017-06-05 14:53 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback+

Attachments
armv6 patch (5.02 KB, patch)
2016-09-07 17:51 UTC, Mikael Urankar 		no flags Details | Diff
armv6 fix (4.18 KB, patch)
2017-02-06 09:24 UTC, Mikael Urankar 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2016-09-07 17:51:50 UTC 
Created attachment 174481 [details]
armv6 patch

Hi,

The attached patch allows the build to succeed.

Thanks in advance.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-09-08 07:59:42 UTC 
Thank you for the patch Mikael.

Did the changes come from an upstream commit/pr/issue?

If so, please either include the references in the patches as a comment header, or add them here as a comment so they can be included in the commit.

Also, does this fix arm builds on FreeBSD 9.x, 10.x and 11.x or should this be version limited? I do not have arm hardware to test, so confirmation of QA (poudriere, etc) passing on those versions would be greatly appreciated. 

If you can, please include them as attachments :)
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2016-09-08 09:51:27 UTC 
The patch is from me.

It builds on 11.x, it should build on 10.x and I have no idea for 9.x (anyway we only build packages for -current as of today)

The attachments are too big: 2.6MB, bugzilla don't accept them.

build log for 11:
http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/spidermonkey185-1.8.5_2_freebsd11.log
Comment 4 Mikael Urankar freebsd_committer freebsd_triage 2017-02-06 09:24:28 UTC 
Created attachment 179670 [details]
armv6 fix

regen after ports r426198
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2017-02-09 18:27:57 UTC 
I tested the earlier patch and it worked for me.  I will re-test with the new one.
Comment 6 Mikael Urankar freebsd_committer freebsd_triage 2017-02-10 09:03:43 UTC 
I only removed the BROKEN_armv6 line
Comment 7 Mikael Urankar freebsd_committer freebsd_triage 2017-05-31 10:27:52 UTC 
ping
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2017-05-31 13:38:25 UTC 
Apologies for the delay Mikael

@Mark can you test and confirm QA for attachment 179670 [details] ?
Comment 9 Mikael Urankar freebsd_committer freebsd_triage 2017-06-01 09:41:52 UTC 
Build logs (too large to attach):
http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/spidermonkey185-1.8.5_3.log
Comment 10 commit-hook freebsd_committer freebsd_triage 2017-06-05 12:36:21 UTC 
A commit references this bug:

Author: kwm
Date: Mon Jun  5 12:36:14 UTC 2017
New revision: 442611
URL: https://svnweb.freebsd.org/changeset/ports/442611

Log:
  Add patches to fix the build on armv6.

  PR:		212462
  Submitted by:	mikael.urankar@gmail.com
  Approved by:	maintainer (koobs@)

Changes:
  head/lang/spidermonkey185/Makefile
  head/lang/spidermonkey185/files/patch-assembler_jit_ExecutableAllocator.h
  head/lang/spidermonkey185/files/patch-assembler_wtf_Platform.h
  head/lang/spidermonkey185/files/patch-configure.in
  head/lang/spidermonkey185/files/patch-nanojit_CodeAlloc.cpp
  head/lang/spidermonkey185/files/patch-nanojit_njcpudetect.h
Comment 11 Kubilay Kocak freebsd_committer freebsd_triage 2017-06-05 14:53:06 UTC 
Assign to committer that resolved

Thanks Koop!