Bug 212464 - science/mbdyn: Update to 1.7.1
Summary: science/mbdyn: Update to 1.7.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-09-07 19:16 UTC by Pedro F. Giffuni
Modified: 2016-09-29 20:02 UTC (History)
2 users (show)

See Also:


Attachments
diff (4.89 KB, patch)
2016-09-07 19:16 UTC, Pedro F. Giffuni
no flags Details | Diff
Updated diff (5.66 KB, patch)
2016-09-18 18:03 UTC, Pedro F. Giffuni
no flags Details | Diff
Updated diff (5.66 KB, patch)
2016-09-18 18:06 UTC, Pedro F. Giffuni
no flags Details | Diff
Updated patch (5.70 KB, patch)
2016-09-23 23:02 UTC, Pedro F. Giffuni
no flags Details | Diff
Updated patch (6.50 KB, patch)
2016-09-27 22:05 UTC, Pedro F. Giffuni
no flags Details | Diff
Updated patch - enable multithreads (7.04 KB, patch)
2016-09-27 22:43 UTC, Pedro F. Giffuni
no flags Details | Diff
Updated patch - enable multithreads (7.18 KB, patch)
2016-09-27 22:55 UTC, Pedro F. Giffuni
no flags Details | Diff
Updated patch - enable multithreads (7.25 KB, patch)
2016-09-28 01:58 UTC, Pedro F. Giffuni
no flags Details | Diff
patch - multithreads with cpp change reverted (7.17 KB, patch)
2016-09-28 21:02 UTC, Pedro F. Giffuni
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni freebsd_committer freebsd_triage 2016-09-07 19:16:48 UTC
Created attachment 174485 [details]
diff

Bring changes from three upstream releases:

https://www.mbdyn.org/userfiles/downloads/CHANGELOG-1.5.txt
https://www.mbdyn.org/userfiles/downloads/CHANGELOG-1.6.txt
https://www.mbdyn.org/userfiles/downloads/CHANGELOG-1.7.txt

(Mostly bug fixes).
Regenerate the diffs.
Comment 1 Wen Heping freebsd_committer freebsd_triage 2016-09-08 08:00:09 UTC
The build failed on FreeBSD-9.

wen
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-09-08 08:48:11 UTC
Port is unmaintained, reporter is committer. Assign accordingly
Comment 3 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-09-08 18:53:24 UTC
(In reply to Wen Heping from comment #1)

Hmm ... if I could see the relevant part of the log, I could evaluate if it makes sense to work on it or if we should just deprecate it for 9.x.
Comment 4 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-09-18 18:03:39 UTC
Created attachment 174923 [details]
Updated diff

Don't spend time on FreeBSD 9.x (at least for now).
Move the Tcl/TK broken message to GiNac since it's broken/outdated.
Tcl/Tk seems to build with newer Tcl/Tk but remains untested.
Comment 5 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-09-18 18:06:07 UTC
Created attachment 174924 [details]
Updated diff

(minor space issue)
Comment 6 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-09-23 23:02:28 UTC
Created attachment 175110 [details]
Updated patch

I was able to fix the build on FreeBSD-9 by using C++11-lib.
Comment 7 Pawel Pekala freebsd_committer freebsd_triage 2016-09-27 19:44:04 UTC
Fails to configure when MPI=on:

http://people.freebsd.org/~pawel/buildlogs/mbdyn-1.7.1-11amd64.log
Comment 8 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-09-27 21:20:15 UTC
(In reply to Pawel Pekala from comment #7)
Ugh ... I can reproduce :-/.

I am checking what is wrong witrh "configure" but it appears MPI support is broken:

http://mail.mbdyn.org/pipermail/mbdyn-users/2011-July/001026.html

Perhaps we should just remove it along with the GiNac support.
Comment 9 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-09-27 22:05:26 UTC
Created attachment 175208 [details]
Updated patch

Tag MPI as broken.

Unfortunately the multithreaded support requires a linux-specific HP extension (atomic_ops).
Comment 10 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-09-27 22:43:31 UTC
Created attachment 175211 [details]
Updated patch - enable multithreads

More surprises:

-Enable multithreaded support with
devel/libatomic_ops
- Remove tcl option it's not supported by configure at all.
Comment 11 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-09-27 22:55:49 UTC
Created attachment 175213 [details]
Updated patch - enable multithreads

Some more "fun":
- add a dependency to libltdl found by stage-qa
Comment 12 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-09-28 01:58:34 UTC
Created attachment 175215 [details]
Updated patch - enable multithreads

Minor cleanup (sorry): finish removing the TCL option.

For the record .. I gave a try at adding netcdf support but we are missing a header and I just couldn't find it.
Comment 13 Pawel Pekala freebsd_committer freebsd_triage 2016-09-28 20:20:49 UTC
I think we should remove broken options unless there is chance they will be fixed in near future. With recent changes port fails to configure on
FreeBSD 9.x again for me:

http://people.freebsd.org/~pawel/buildlogs/mbdyn-1.7.1-9amd64.log
Comment 14 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-09-28 21:02:36 UTC
Created attachment 175237 [details]
patch - multithreads with cpp change reverted

Sorry, this should fix it.

Explanation: the configure script hardcodes the "cpp" value. This appears to be harmless but in the previous patch I tried to change it to the cpp that comes with GCC but there doesn't seem to be a consistent value on FreeBSD 9.x. I again undid the change leaving the hardcoded value: it's strange but it still works.

I agree the broken options are ugly.  GiNac seems fixable but in general the port has some ugly brokenness: the PAM option doesn't work either.
Comment 15 commit-hook freebsd_committer freebsd_triage 2016-09-29 20:02:28 UTC
A commit references this bug:

Author: pawel
Date: Thu Sep 29 20:01:41 UTC 2016
New revision: 422945
URL: https://svnweb.freebsd.org/changeset/ports/422945

Log:
  - Update to version 1.7.1 [1]
  - Enable multithreaded support with devel/libatomic_ops [1]
  - Remove not supported TCL option [1]
  - Add LICENSE_FILE
  - Convert to options helpers

  https://www.mbdyn.org/userfiles/downloads/CHANGELOG-1.5.txt
  https://www.mbdyn.org/userfiles/downloads/CHANGELOG-1.6.txt
  https://www.mbdyn.org/userfiles/downloads/CHANGELOG-1.7.txt

  PR:		212464 [1]
  Submitted by:	pfg [1]

Changes:
  head/science/mbdyn/Makefile
  head/science/mbdyn/distinfo
  head/science/mbdyn/files/patch-include__ac__mpi.h
  head/science/mbdyn/files/patch-mbdyn__base__invsolver.cc
  head/science/mbdyn/files/patch-mbdyn__base__solver.cc
  head/science/mbdyn/files/patch-mbdyn__mbdyn.h
  head/science/mbdyn/pkg-plist