Created attachment 174494 [details] sieve-connect-0.88.diff This is update of mail/sieve-connect to 0.88 version. Also, LICENSE is fixed to what is specified in original source. Changes in v0.88: * (BREAKING CHANGE) Require TLS verification to work. * (POSSIBLY BREAKING CHANGE) Remote sieve name should be basename of local. * Fail early if no CA trust anchors can be found but TLS verification is enabled. * Added `--tlshostname` option to override the hostname used for TLS host identity verification * If not interactive, various warnings in interactive at the application-level with the remote server will now trigger a final warning before exit and a non-zero exit code. * Kolab nocaps server compatibility, in the continuing saga of "feature-based negotiation, who needs it anyway?" * build-system fix to better isolate releaser tools from "just make the tarball", to let others make the unsigned tarball and compare. * Interactive command `debug` added when invoked with `--debug` to toggle debugging off/on, to reduce self-inflicted log-spam. * Handle local hostnames which lack real DNS better, avoid an undef dereference Full ChangeLog at: http://people.spodhuis.org/phil.pennock/software/sieve-connect.ChangeLog.txt
Created attachment 174495 [details] sieve-connect-0.88.diff
@Alexey, in future set maintainer-approval to + on attachments for ports you are maintainer of. Attachment -> Details -> maintainer-approval [+]. Also, please confirm this change passes QA (portlint, poudriere) Thank you!
- Patch does not apply: Patching file distinfo using Plan A... Hunk #1 succeeded at 1 with fuzz 2. patch: **** misordered hunks! output would be garbled - LICENSE should not be BSD (echo DEVELOPER=yes >> /etc/make.conf, compile port) - Breaking changes should be listed in UPDATING file, not pkg-message's
Dmitry, how did you apply the patch? See no error on my side: root@freebsd:/usr/ports/mail # patch -s -p0 < /tmp/sieve-connect-0.88.diff root@freebsd:/usr/ports/mail # echo $? 0
As for breaking changes in UPDATING. This file is part of ports infrastructure, but this note is intended for people using packages as well. I am not sure that people using package only installs will have a chance to see that message unless it is in pkg-message.
Created attachment 174522 [details] sieve-connect-0.88.1.diff LICENSE=BSD3CLAUSE portlint and poudriere are ok with that change
Thank you Alexey
(In reply to alexey from comment #5) > As for breaking changes in UPDATING. This file is part of ports > infrastructure, but this note is intended for people using packages as well. > I am not sure that people using package only installs will have a chance to > see that message unless it is in pkg-message. Not true, see `pkg updating`. pkg-message is for notes that always apply to the port, UPDATING is for one-time changes which needed to be performed manually during upgrade and applies to both ports and packages.
Created attachment 174687 [details] sieve-connect-0.88.2.diff
According to what you propose, most people will likely note a new behaviour when sieve-connect will refuse to operate. With pkg-message the message will appear right after package update, therefore the user will know about possible errors immediately. Your approach is pretty painful rather than user friendly, so people would 'thank' you, not me for the inconvenience due to not being notified about breaking changes promptly. In order to update the port instead of going into holy war while discussion, I'm attaching a new patch. But please note that it is not my intention to do like this. I am still disagree to move that note from pkg-message to UPDATING. root@freebsd:/usr/ports # patch -s -p0 < /tmp/sieve-connect-0.88.2.diff root@freebsd:/usr/ports # echo $? 0 portlint and poudriere are also ok
Now what we are waiting for, please?
A commit references this bug: Author: amdmi3 Date: Wed Sep 21 15:36:04 UTC 2016 New revision: 422568 URL: https://svnweb.freebsd.org/changeset/ports/422568 Log: - Update mail/sieve-connect to 0.88 - Fix LICENSE Changes in v0.88: * (BREAKING CHANGE) Require TLS verification to work. * (POSSIBLY BREAKING CHANGE) Remote sieve name should be basename of local. * Fail early if no CA trust anchors can be found but TLS verification is enabled. * Added `--tlshostname` option to override the hostname used for TLS host identity verification * If not interactive, various warnings in interactive at the application-level with the remote server will now trigger a final warning before exit and a non-zero exit code. * Kolab nocaps server compatibility, in the continuing saga of "feature-based negotiation, who needs it anyway?" * build-system fix to better isolate releaser tools from "just make the tarball", to let others make the unsigned tarball and compare. * Interactive command `debug` added when invoked with `--debug` to toggle debugging off/on, to reduce self-inflicted log-spam. * Handle local hostnames which lack real DNS better, avoid an undef dereference Full ChangeLog at: http://people.spodhuis.org/phil.pennock/software/sieve-connect.ChangeLog.txt PR: 212466 Submitted by: alexey@renatasystems.org (maintainer) Changes: head/UPDATING head/mail/sieve-connect/Makefile head/mail/sieve-connect/distinfo
> Your approach is pretty painful rather than user friendly, so people would 'thank' you, not me for the inconvenience due to not being notified about breaking changes promptly. On the opposite. First, people look for breaking changes in UPDATING, not pkg-messages, so the message will actually be noticed. Next, UPDATING may be viewed before actually updating the port/package, so users may prepare for changes without breaking their installation with updating first. Last, but not least, people will thank you for not polluting pkg-message with information completely unrelated to them for any case of package installation which is not update from before 0.88.