Bug 212556 - sysutils/tarsnap-periodic: Fix tarsnap-backup script
Summary: sysutils/tarsnap-periodic: Fix tarsnap-backup script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
: 212582 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-09-10 08:05 UTC by Jose Luis Duran
Modified: 2016-10-06 16:35 UTC (History)
1 user (show)

See Also:
kamila: maintainer-feedback+

Attachments
PATCH tarsnap-backup script (2.75 KB, patch)
2016-09-10 08:05 UTC, Jose Luis Duran 		no flags Details | Diff
PORTVERSION bump (427 bytes, patch)
2016-09-11 10:25 UTC, Jose Luis Duran 		no flags Details | Diff
Bump to version 1.0.20160911 (988 bytes, patch)
2016-09-14 01:37 UTC, Jose Luis Duran 		no flags Details | Diff
Bump version 1.0.20160911 (1.15 KB, patch)
2016-09-14 01:46 UTC, Jose Luis Duran 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Luis Duran freebsd_committer freebsd_triage 2016-09-10 08:05:16 UTC 
Created attachment 174614 [details]
PATCH tarsnap-backup script

Pull Request submitted upstream:

https://github.com/AnotherKamila/tarsnap-periodic/pull/1

- Fix if [ -n something_wrong ];
- Apply ShellCheck recommendations:
  - Double quote variables to prevent globbing and word splitting
  - Use $(..) instead of legacy `..`
  - expr is antiquated. Rewrite using $((..))
Comment 1 Jose Luis Duran freebsd_committer freebsd_triage 2016-09-11 10:12:43 UTC 
This patch has been accepted upstream.  Only a PORTREVISION bump is needed.
Comment 2 Jose Luis Duran freebsd_committer freebsd_triage 2016-09-11 10:25:27 UTC 
Created attachment 174648 [details]
PORTVERSION bump

The previous patch was committed upstream.
Comment 3 Kamila Součková 2016-09-11 12:54:08 UTC 
Created bug #212582 to submit the updated Makefile.
Comment 4 Kamila Součková 2016-09-11 13:00:53 UTC 
*** Bug 212582 has been marked as a duplicate of this bug. ***
Comment 5 Kamila Součková 2016-09-11 13:02:40 UTC 
Disregard comment #3 (sorry, new to FreeBSD ports). Will approve the patch.
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2016-09-13 20:01:34 UTC 
You submissoin missies regenerated distinfo
Comment 7 Jose Luis Duran freebsd_committer freebsd_triage 2016-09-14 01:37:48 UTC 
Created attachment 174764 [details]
Bump to version 1.0.20160911

Bump to version 1.0.20160911
Comment 8 Jose Luis Duran freebsd_committer freebsd_triage 2016-09-14 01:46:58 UTC 
Created attachment 174765 [details]
Bump version 1.0.20160911

Add License
Comment 9 Jose Luis Duran freebsd_committer freebsd_triage 2016-09-14 01:47:44 UTC 
(In reply to Dmitry Marakasov from comment #6)

Sorry about that. This patch includes the license information as well.
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-10-06 16:35:30 UTC 
A commit references this bug:

Author: amdmi3
Date: Thu Oct  6 16:35:10 UTC 2016
New revision: 423417
URL: https://svnweb.freebsd.org/changeset/ports/423417

Log:
  - Update to 1.0.20160911
  - Add LICENSE

  PR:		212556
  Submitted by:	jlduran@gmail.com
  Approved by:	kamila@ksp.sk (maintainer)

Changes:
  head/sysutils/tarsnap-periodic/Makefile
  head/sysutils/tarsnap-periodic/distinfo