Bug 212671 - net-mgmt/riemann: tweaks - update distfile, add conf.d, label daemon & get service reload working
Summary: net-mgmt/riemann: tweaks - update distfile, add conf.d, label daemon & get se...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-13 23:17 UTC by Dave Cottlehuber
Modified: 2016-11-11 06:00 UTC (History)
1 user (show)

See Also:
dch: maintainer-feedback+

Attachments
v1 patch (1.66 KB, text/plain)
2016-09-13 23:17 UTC, Dave Cottlehuber 		no flags Details
v2 patch now with SIGHUP (2.02 KB, patch)
2016-09-14 10:53 UTC, Dave Cottlehuber 		dch: maintainer-approval+
Details | Diff
v3 (2.58 KB, patch)
2016-09-19 19:06 UTC, Dave Cottlehuber 		no flags Details | Diff
v4 patch final (3.00 KB, patch)
2016-11-08 00:19 UTC, Dave Cottlehuber 		dch: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Cottlehuber freebsd_committer freebsd_triage 2016-09-13 23:17:22 UTC 
Created attachment 174756 [details]
v1 patch

# QA

- portlint OK
- poudriere OK on 11_amd64_rc2

# Changes

- riemann project now uses github release for software artefacts
- a conf.d directory was added for loading additional config files
Comment 1 Dave Cottlehuber freebsd_committer freebsd_triage 2016-09-14 10:53:34 UTC 
Created attachment 174774 [details]
v2 patch now with SIGHUP
Comment 2 Dave Cottlehuber freebsd_committer freebsd_triage 2016-09-14 10:54:09 UTC 
(In reply to Dave Cottlehuber from comment #1)

v2 patch

# QA

- portlint OK
- poudriere OK on 11_amd64_rc2

# Changes

- riemann project now uses github release for software artefacts
- a conf.d directory was added for loading additional config files
- teach rc.d script to use SIGHUP to reload config
Comment 3 Dave Cottlehuber freebsd_committer freebsd_triage 2016-09-19 19:06:09 UTC 
Created attachment 174971 [details]
v3

needs further work, as the SIGHUP from `service reload` is not propagated through by daemon. Not sure how to tackle this just yet.
Comment 4 Dave Cottlehuber freebsd_committer freebsd_triage 2016-11-08 00:19:39 UTC 
Created attachment 176752 [details]
v4 patch final
Comment 5 Dave Cottlehuber freebsd_committer freebsd_triage 2016-11-08 00:32:05 UTC 
# v4 patch changes

- fix reload under daemon(8) using pkill
- use new upstream master site
- add conf.d for more complex configurations
- add named daemon(8) process info
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2016-11-08 20:51:10 UTC 
If the new master_site is github, why don't you use USE_GITHUB=yes etc ?
Comment 7 Dave Cottlehuber freebsd_committer freebsd_triage 2016-11-09 07:35:20 UTC 
Good question, at present the distributed release artefact is a .jar
file and not a direct artefact from the source build process.

I'd prefer to commit these changes and then investigate building
riemann completely from sources in a later stage, as maven & so forth
are as yet unknown to me.
Comment 8 Dave Cottlehuber freebsd_committer freebsd_triage 2016-11-09 09:26:57 UTC 
Sorry in case that wasn't quite clear, one's a source tarball
and the other is a runnable .jar file.

At present we use the generated artefact (created via
`lein uberjar` from a source checkout but requires maven and
network access normally), uploaded when the project does its
builds, from https://github.com/riemann/riemann/releases/download/0.2.11/riemann-0.2.11.tar.bz2

USE_GITHUB only downloads a source tarball from https://codeload.github.com/riemann/riemann/tar.gz/0.2.11?dummy=/riemann-riemann-0.2.11_GH0.tar.gz
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-11-11 05:54:27 UTC 
A commit references this bug:

Author: pi
Date: Fri Nov 11 05:53:44 UTC 2016
New revision: 425861
URL: https://svnweb.freebsd.org/changeset/ports/425861

Log:
  net-mgmt/riemann: several changes to the port itself

  - fix reload under daemon(8) using pkill
  - use new upstream master site
  - add conf.d for more complex configurations
  - add named daemon(8) process info

  PR:		212671
  Submitted by:	Dave Cottlehuber <dch@skunkwerks.at> (maintainer)

Changes:
  head/net-mgmt/riemann/Makefile
  head/net-mgmt/riemann/distinfo
  head/net-mgmt/riemann/files/riemann.in
  head/net-mgmt/riemann/pkg-plist
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2016-11-11 06:00:27 UTC 
Committed, thanks!