Created attachment 174760 [details] py-twitter-3.1.patch - Update to 3.1 - Add BUILD_DEPENDS (devel/py-pytest-runner) Changelog: https://github.com/bear/python-twitter/blob/master/doc/changelog.rst portlint: OK (looks fine.) testport: poudriere: i386, 10.3 (OK) poudriere: amd64, 10.3 (OK) poudriere: i386, 9.3 (OK) poudriere: amd64, 9.3 (OK) poudriere: i386, 12 (OK) poudriere: amd64, 12 (OK)
@Danilo, Even though it is listed in setup_requires, pytest-runner should not be a build dependency. Can you test using the test suite after patching this out please. Also, this port (net/py-twitter) needs to be renamed to py-python-twitter (python-twitter @ PyPI) The correct net/py-twitter (twitter @ PyPI) is the currently named net/py-twitter-tools.
Created attachment 175591 [details] py-python-twitter-3.1-v02.patch Hi koobs@ thanks for the feedback. Could you check it again, please ? - Rename to py-python-twitter, following PyPI - Update to 3.1 - Include a patch to ignore a test dependency Changelog: https://github.com/bear/python-twitter/blob/master/doc/changelog.rst It's fine to move this port from net/py-twitter to net/py-python-twitter, it's not used as dependencies of any port. I've used svn move for testing on my environment. How should I proceed with this, patching net/Makefile and MOVED ? Or a developer could do this ? [QA] portlint: OK (looks fine.) testport: poudriere: i386, 10.3 (OK) poudriere: amd64, 10.3 (OK) poudriere: i386, 9.3 (OK) poudriere: amd64, 9.3 (OK) poudriere: i386, 12 (OK) poudriere: amd64, 12 (OK)
(In reply to Danilo G. Baio (dbaio) from comment #2) The changes look fine Danilo, thank you. Do the unit tests pass? (running python setup.py test, to confirm everything is OK at runtime, without pytest-runner installed at build time). pytest-runner may be needed in setup.py:tests_require (so that setup.py test installs it if not already installed). If this is the case we can submit the change upstream as well. Feel free to include the net/Makefile changes and the addition to MOVED as well. The committer taking care of this can do the 'svn mv' part
Created attachment 175666 [details] py-python-twitter-3.1-v03.patch Hi @koobs. Tests are not included at PyPi package[1], so I've moved MASTER_SITES to Github. [1] - packages=find_packages(exclude=('tests', 'docs')), New patch: - Rename to py-python-twitter, following PyPI/Github name - Update to 3.1 - Move to Github - Include a patch to ignore a test dependency Changelog: https://github.com/bear/python-twitter/blob/master/doc/changelog.rst [QA] portlint: OK (looks fine.) testport: poudriere: i386, 9.3 (OK) poudriere: amd64, 9.3 (OK) poudriere: i386, 10.3 (OK) poudriere: amd64, 10.3 (OK) poudriere: i386, 11 (OK) poudriere: amd64, 11 (OK) poudriere: i386, 12 (OK) poudriere: amd64, 12 (OK) py.test (without pytest-runner installed) --------------------------------------------------------------------- test session starts platform freebsd12 -- Python 2.7.12, pytest-2.8.7, py-1.4.31, pluggy-0.3.1 rootdir: /usr/home/dbaio/FreeBSD/ports/net/py-python-twitter/work/python-twitter-3.1, inifile: pytest.ini collected 148 items tests/test_api.py sssssssssssssssss tests/test_api_30.py ......................................................................... tests/test_filecache.py ..... tests/test_media.py ...... tests/test_models.py ........... tests/test_parse_tweet.py .. tests/test_rate_limit.py ....... tests/test_status.py ...... tests/test_trend.py .... tests/test_tweet_length.py .. tests/test_twitter_utils.py .... tests/test_unicode.py ..... tests/test_user.py ...... 131 passed, 17 skipped in 4.67 seconds ---------------------------------------------------------------------
Very nice work Danilo, thank you.
Created attachment 176079 [details] py-python-twitter-3.1-v04.patch Sorry, I checked again this issue and the MOVED file was incorrect. I tried create a patch with "svn move", but with "svn diff --patch-compatible" history was lost, and using just a "svn diff" when applied didn't work correctly. So, the best approach based on comment 3 and some tests was this: $ svn patch /tmp/py-python-twitter-3.1-v04.patch U MOVED U net/Makefile U net/py-twitter/Makefile U net/py-twitter/distinfo A net/py-twitter/files A net/py-twitter/files/patch-setup.py $ svn move net/py-twitter/ net/py-python-twitter/ A net/py-python-twitter D net/py-twitter D net/py-twitter/Makefile D net/py-twitter/distinfo D net/py-twitter/files D net/py-twitter/files/patch-setup.py D net/py-twitter/pkg-descr $ svn status M MOVED M net/Makefile A + net/py-python-twitter > moved from net/py-twitter M + net/py-python-twitter/Makefile M + net/py-python-twitter/distinfo A net/py-python-twitter/files A net/py-python-twitter/files/patch-setup.py D net/py-twitter > moved to net/py-python-twitter D net/py-twitter/Makefile D net/py-twitter/distinfo D net/py-twitter/pkg-descr Fix permissions [1]: chmod 644 MOVED net/Makefile net/py-python-twitter/Makefile net/py-python-twitter/distinfo [1] - https://issues.apache.org/jira/browse/SVN-4651 portlint and testport are fine.
Comment on attachment 176079 [details] py-python-twitter-3.1-v04.patch obsolete by ports r429047 and ports r429209
I'll take this PR and submit it to a review, thanks.
Thanks Danilo, please add review URL to URL field in Bugzilla when created
A commit references this bug: Author: dbaio Date: Tue May 16 01:09:34 UTC 2017 New revision: 440987 URL: https://svnweb.freebsd.org/changeset/ports/440987 Log: net/py-twitter: Rename to py-python-twitter Renamed to reflect official name at PyPI/Github. PR: 212673 Approved by: garga (mentor), python (miwi) Differential Revision: https://reviews.freebsd.org/D10705 Changes: head/MOVED head/net/Makefile head/net/py-python-twitter/ head/net/py-python-twitter/Makefile head/net/py-twitter/