Bug 212788 - [patch] mail/dovecot2 rc script change test -f to test -s
Summary: [patch] mail/dovecot2 rc script change test -f to test -s
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-09-18 09:15 UTC by Olli Hauer
Modified: 2016-09-18 16:47 UTC (History)
0 users

See Also:
adamw: maintainer-feedback+

Attachments
better test parameter (477 bytes, patch)
2016-09-18 09:15 UTC, Olli Hauer 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Hauer freebsd_committer freebsd_triage 2016-09-18 09:15:10 UTC 
Created attachment 174903 [details]
better test parameter

The rc script should not only check if a config file is available but also if it is empty.
To reach this change the test clause from "-f" to "-s".

Sure this will not guaranty the config contains useful information but prevents dovecot to start with an empty config file
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2016-09-18 15:27:16 UTC 
Seems like a good idea, please commit this!
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-09-18 16:38:38 UTC 
A commit references this bug:

Author: ohauer
Date: Sun Sep 18 16:38:28 UTC 2016
New revision: 422397
URL: https://svnweb.freebsd.org/changeset/ports/422397

Log:
  - test config file with param '-s' instead '-f'

  PR:		212788
  Submitted by:	ohauer
  Reviewed by:	adamw
  Approved by:	adamw (maintainer)

Changes:
  head/mail/dovecot2/files/dovecot.in
Comment 3 Olli Hauer freebsd_committer freebsd_triage 2016-09-18 16:39:48 UTC 
Committed!
Comment 4 Adam Weinberger freebsd_committer freebsd_triage 2016-09-18 16:40:24 UTC 
Please bump PORTREVISION too.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-09-18 16:47:40 UTC 
A commit references this bug:

Author: ohauer
Date: Sun Sep 18 16:46:57 UTC 2016
New revision: 422399
URL: https://svnweb.freebsd.org/changeset/ports/422399

Log:
  - bump PORTREVISION

  PR:		212788

Changes:
  head/mail/dovecot2/Makefile
  head/mail/dovecot2-antispam-plugin/Makefile
  head/mail/dovecot2-pigeonhole/Makefile