Bug 212901 - sysutils/lsof fails to build on base/head after r305902
Summary: sysutils/lsof fails to build on base/head after r305902
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-22 13:22 UTC by Trond Endrestøl
Modified: 2016-09-22 21:53 UTC (History)
2 users (show)

See Also:
ler: maintainer-feedback+

Attachments
Patch for dialects/freebsd/dnode.c (721 bytes, patch)
2016-09-22 13:22 UTC, Trond Endrestøl 		no flags Details | Diff
make makepatch version of the patch (701 bytes, patch)
2016-09-22 14:43 UTC, Larry Rosenman 		no flags Details | Diff
make makepatch version of the patch (701 bytes, patch)
2016-09-22 14:44 UTC, Larry Rosenman 		no flags Details | Diff
port upgrade patch (1.70 KB, patch)
2016-09-22 14:45 UTC, Larry Rosenman 		no flags Details | Diff
upgrade patch to 4.90G (929 bytes, patch)
2016-09-22 21:31 UTC, Larry Rosenman 		no flags Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2016-09-22 13:22:01 UTC 
Created attachment 175061 [details]
Patch for dialects/freebsd/dnode.c

Change from using i_dev to using i_ump->um_dev. See attached patch.
Comment 1 Larry Rosenman freebsd_committer freebsd_triage 2016-09-22 14:27:58 UTC 
I will run this by Vic Abell (author).  I had sent him mail, but he didn't know when he would get to it.
Comment 2 Larry Rosenman freebsd_committer freebsd_triage 2016-09-22 14:43:25 UTC 
Created attachment 175063 [details]
make makepatch version of the patch
Comment 3 Larry Rosenman freebsd_committer freebsd_triage 2016-09-22 14:44:49 UTC 
Created attachment 175064 [details]
make makepatch version of the patch
Comment 4 Larry Rosenman freebsd_committer freebsd_triage 2016-09-22 14:45:44 UTC 
Created attachment 175065 [details]
port upgrade patch
Comment 5 Larry Rosenman freebsd_committer freebsd_triage 2016-09-22 14:47:16 UTC 
I did a test compile, and it works, I regenerated the patch using make makepatch, after removing the DOS line-ends. 

Committer: Please be aware of adding the patch.
Comment 6 Larry Rosenman freebsd_committer freebsd_triage 2016-09-22 19:14:35 UTC 
Please hold off on this, Vic says the patch won't work, and is working on a new one.
Comment 7 Larry Rosenman freebsd_committer freebsd_triage 2016-09-22 21:31:25 UTC 
Created attachment 175076 [details]
upgrade patch to 4.90G

Vic Abell generated a new release (4.90G) to cope with this, upgrade attached.
Comment 8 Adam Weinberger freebsd_committer freebsd_triage 2016-09-22 21:37:44 UTC 
Hi Larry,

I'm watching the thread here but it's your show. Keep doing what you're doing, and when you're ready, tell me to commit it.

Also, if Trond's patch is no longer relevant, please mark it as obsolete.
Comment 9 Larry Rosenman freebsd_committer freebsd_triage 2016-09-22 21:40:16 UTC 
Comment on attachment 175061 [details]
Patch for dialects/freebsd/dnode.c

this patch is obsolete.
Comment 10 Adam Weinberger freebsd_committer freebsd_triage 2016-09-22 21:42:29 UTC 
Sorry, forgot that you might not be able to mark someone else's patch as obsolete.
Comment 11 Larry Rosenman freebsd_committer freebsd_triage 2016-09-22 21:43:02 UTC 
Please commit the 4.90G version which is the official fix. 

I couldn't mark Trond's obsolete, BZ wouldn't take it :(
Comment 12 commit-hook freebsd_committer freebsd_triage 2016-09-22 21:52:05 UTC 
A commit references this bug:

Author: adamw
Date: Thu Sep 22 21:51:48 UTC 2016
New revision: 422641
URL: https://svnweb.freebsd.org/changeset/ports/422641

Log:
  Update to 4.90G.

  Includes:
    - Change from using i_dev to using i_ump->um_dev

  PR:		212901
  Submitted by:	Trond Endrestol
  Approved by:	maintainer (Larry Rosenman)

Changes:
  head/sysutils/lsof/Makefile
  head/sysutils/lsof/distinfo
Comment 13 Adam Weinberger freebsd_committer freebsd_triage 2016-09-22 21:53:56 UTC 
(In reply to Larry Rosenman from comment #11)

Done. Thanks for that patch, Trond!

Larry, can you look into getting lsof to acknowledge the "make test" target?