Bug 212955 - shells/fish 2.3.1: backspace is broken with UTF-8 terminals
Summary: shells/fish 2.3.1: backspace is broken with UTF-8 terminals
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/fish-shell/fish-sh...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2016-09-24 03:01 UTC by Alan Somers
Modified: 2017-01-03 17:53 UTC (History)
4 users (show)

See Also:
vlad-fbsd: maintainer-feedback? (freebsd.users)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2016-09-24 03:01:33 UTC 
I'm using TrueOS beta.  fish 2.2.0 worked fine.  But after upgrading to fish 2.3.1, the backspace key is ignored and the arrow keys enter "[D", "[A", "[C", and "[B".  Delete, Home, End and Page Up/Down also enter similar garbage.  Oddly, these keys work fine virtual terminal.  Also, bash works fine with QTerminal 0.6.  So the problem seems to be an interaction between QTerminal and Fish 2.3.1.  I've verified that rebuilding Fish 2.2.0 from ports fixes the problem.  Next, I'll try bisecting the upstream source to find the cause of the bug.
Comment 1 Alan Somers freebsd_committer freebsd_triage 2016-09-24 05:05:37 UTC 
Upstream issue
https://github.com/fish-shell/fish-shell/issues/3406
Comment 2 Jason W. Bacon freebsd_committer freebsd_triage 2016-09-24 13:00:22 UTC 
Check your TERM and COLORTERM env variables.  Your shell may be looking for the wrong magic sequences since the last revision.
Comment 3 VK 2016-10-04 09:03:17 UTC 
Request maintainer feedback for shells/fish.
Comment 4 Alan Somers freebsd_committer freebsd_triage 2016-10-04 15:14:14 UTC 
Review in progress at https://reviews.freebsd.org/D8148
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2016-10-04 19:38:59 UTC 
testbuild@work
Comment 6 Alan Somers freebsd_committer freebsd_triage 2016-10-25 15:01:32 UTC 
Was the test build successful?
Comment 7 mmatalka 2016-10-28 18:05:00 UTC 
Hello, any update on this?  I'm on TrueOS as well and experiencing this bug.
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-01-03 17:51:13 UTC 
A commit references this bug:

Author: asomers
Date: Tue Jan  3 17:50:50 UTC 2017
New revision: 430488
URL: https://svnweb.freebsd.org/changeset/ports/430488

Log:
  shells/fish upgrade to 2.4.0

  Also, update /etc/shells on install

  PR:		214306, 212955
  Approved by:	brd (ports) freebsd.users@gmail.com (maintainer timeout)
  Sponsored by:	Spectra Logic Corp
  Differential Revision:	https://reviews.freebsd.org/D8665

Changes:
  head/shells/fish/Makefile
  head/shells/fish/distinfo
  head/shells/fish/pkg-plist
Comment 9 Alan Somers freebsd_committer freebsd_triage 2017-01-03 17:53:22 UTC 
Fixed by svn r430488 (PR 214306), which updates shells/fish to a version where the problem is fixed by upstream.