Bug 213042 - devel/astyle: build according to $COMPILER_TYPE and simplify Makefile
Summary: devel/astyle: build according to $COMPILER_TYPE and simplify Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lars Engels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-28 09:59 UTC by Boris Samorodov
Modified: 2016-10-04 21:52 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (lme)

Attachments
build according to $COMPILER_TYPE and simplify Makefile (870 bytes, patch)
2016-09-28 09:59 UTC, Boris Samorodov 		no flags Details | Diff
Revised full patch (+removed target pre-patch) (797 bytes, patch)
2016-09-28 10:21 UTC, Boris Samorodov 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Samorodov freebsd_committer freebsd_triage 2016-09-28 09:59:23 UTC 
Created attachment 175223 [details]
build according to $COMPILER_TYPE and simplify Makefile

. currently the port uses "astyle/build/gcc" build directory. Let's use (guess, a more appropriate) "astyle/build/${COMPILER_TYPE}";
. remove redundant doubled CFLAGS:
---
clang++ -DNDEBUG -W -Wall -fno-rtti -fno-exceptions -O2 -pipe  -W -Wall -fno-rtti -fno-exceptions -DLIBICONV_PLUG -fstack-protector -fno-strict-aliasing -I/usr/local/include -c -o obj/ASBeautifier.o ../../src/ASBeautifier.cpp
---
. remove now blank MAKE_ARGS;
. remove now unneeded one sed option;
. since "-s" linker flag, the resulting file is already stripped, remove stripping from do-install target.

There is no revision bump needed since the resulting file is the same.
Comment 1 Boris Samorodov freebsd_committer freebsd_triage 2016-09-28 10:21:28 UTC 
Created attachment 175224 [details]
Revised full patch (+removed target pre-patch)

Actually, the other sed option at pre-patch target is not needed. Remove the whole target.

Revised full patch is attached.
Comment 2 Lars Engels freebsd_committer freebsd_triage 2016-10-04 21:42:16 UTC 
Thanks for the PR. I'll take a look!
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-10-04 21:51:54 UTC 
A commit references this bug:

Author: lme
Date: Tue Oct  4 21:51:16 UTC 2016
New revision: 423305
URL: https://svnweb.freebsd.org/changeset/ports/423305

Log:
  devel/astyle:

  - Remove doubled CLFAGS
  - Use astyle/build/${COMPILER_TYPE} as WRCSRC instead of hard-coding gcc
  - Remove blank MAGE_ARGS
  - Drop no longer needed pre-patch target
  - Stripping the binary is now done by the linker itself

  PR:		    213042
  Submitted by:	bsam

Changes:
  head/devel/astyle/Makefile
Comment 4 Lars Engels freebsd_committer freebsd_triage 2016-10-04 21:52:29 UTC 
Committed, thanks!