Created attachment 175300 [details] shar This port contains detok, romheaders and toke utilities. It's helpful in e.g. decoding firmware images. Portlint says it's fine, and it build fine on Poudriere with 10.3.
Build fails on FreeBSD 9: http://people.freebsd.org/~pawel/buildlogs/fcode-utils-1.0.2-9amd64.log XLICENSE= GPLv2 Please add LICENSE_FILE if copy of license is available. Xpre-patch: X ${REINPLACE_CMD} -e 's/gcc/cc/' ${WRKSRC}/detok/Makefile \ X ${WRKSRC}/romheaders/Makefile ${WRKSRC}/toke/Makefile cc should be changed to ${CC} so port respects user set compiler. Xdo-install: X ${CP} ${WRKSRC}/detok/detok ${WRKSRC}/toke/toke \ X ${WRKSRC}/romheaders/romheaders ${STAGEDIR}${PREFIX}/bin/ ${CP} should not be used to install files, we have ${INSTALL_*} macros that make sure files are installed with proper permissions. Looks like ${INSTALL_PROGRAM} would be good match here if installed files are binary executables.
Created attachment 175700 [details] shar (In reply to Pawel Pekala from comment #1) "Build fails on FreeBSD 9:" Fixed. "Please add LICENSE_FILE if copy of license is available." Done. "cc should be changed to ${CC} so port respects user set compiler." Done. "${CP} should not be used to install files, we have ${INSTALL_*} macros that make sure files are installed with proper permissions. Looks like ${INSTALL_PROGRAM} would be good match here if installed files are binary executables." Done.
make test fails: 20:46:49 177 99 ExamAllMacs.scr: Command not found. 90 DtkVSFcTst.scr: Command not found. 20:46:59 20:46:49 (Started) CygTestLogs=/usr/local/ports/sysutils/fcode-utils/work/fcode-utils-1.0.2/testlogs/testlogs-ppc-linux csh AutoCompare List of TestArgs files in CygTestLogs (/usr/local/ports/sysutils/fcode-utils/work/fcode-utils-1.0.2/testlogs/testlogs-ppc-linux) directory does not match those found under current directory. Please correct discrepancy and try again. gmake[2]: *** [Makefile:8: compare] Błąd 8 gmake[2]: Opuszczenie katalogu '/usr/local/ports/sysutils/fcode-utils/work/fcode-utils-1.0.2/testsuite' gmake[1]: *** [Makefile:54: tests] Błąd 2 gmake[1]: Opuszczenie katalogu '/usr/local/ports/sysutils/fcode-utils/work/fcode-utils-1.0.2' *** Error code 1
No response in long while.
Created attachment 178118 [details] shar Sorry it took so long but I just used fcode-utils on Linux for what I needed and quite forgot about this PR :) Tests seem not to work, but the binaries itself are just fine, so I'm removing tests from the shar.
ping!
(In reply to w.schwarzenfeld from comment #6) What do you want we to do? I just tested this shar again and binaries work fine.
A commit references this bug: Author: tobik Date: Wed May 9 12:59:38 UTC 2018 New revision: 469447 URL: https://svnweb.freebsd.org/changeset/ports/469447 Log: New port: sysutils/fcode-utils A set of utilities to process FCODE, OpenFirmware's byte code. This includes: - the tokenizer toke, - the detokenizer detok, - and a PCI rom header utility. WWW: https://www.openfirmware.info/FCODE_suite PR: 213114 Submitted by: Piotr Kubaj <pkubaj@anongoth.pl> (based on) Reviewed by: pawel Changes: head/sysutils/Makefile head/sysutils/fcode-utils/ head/sysutils/fcode-utils/Makefile head/sysutils/fcode-utils/distinfo head/sysutils/fcode-utils/files/ head/sysutils/fcode-utils/files/patch-shared_types.h head/sysutils/fcode-utils/pkg-descr
Committed. Thanks! I took the liberty of also installing the documentation that was in the tarball.
(In reply to Piotr Kubaj from comment #7) > What do you want we to do? I just tested this shar again and binaries work fine. When bugs have been open for some time it's always nice to get some confirmation that the bug is still relevant.