Created attachment 175351 [details] rtv-1.12.1.patch - Update to 1.12.1 - Remove python version limit 3.3+ - Remove dependency www/py-tornado not used anymore - Add new dependencies: www/py-requests www/py-beautifulsoup devel/py-decorator devel/py-mailcap-fix devel/py-update_checker - Fix duplicate entry of dependency devel/py-six - Small change on pkg-descr (line with more than 80 characters) - Set architecture neutral - Take maintainer'ship Changelog: https://github.com/michael-lazar/rtv/blob/master/CHANGELOG.rst portlint: OK (looks fine.) testport: python 2.7 and 3.4 poudriere: i386, 10.3 (OK) poudriere: amd64, 10.3 (OK) poudriere: i386, 9.3 (OK) poudriere: amd64, 9.3 (OK) poudriere: i386, 12 (OK) poudriere: amd64, 12 (OK)
Created attachment 175953 [details] rtv-1.13.0.patch rtv was updated, updating patch. - Update to 1.13.0 - Remove python version limit 3.3+ - Remove dependency www/py-tornado not used anymore - Add new dependencies: www/py-requests www/py-beautifulsoup devel/py-decorator devel/py-mailcap-fix devel/py-update_checker - Fix duplicate entry of dependency devel/py-six - Small change on pkg-descr (line with more than 80 characters) - Install manpage(1) properly - Set architecture neutral - Take maintainer'ship Changelog: https://github.com/michael-lazar/rtv/blob/master/CHANGELOG.rst [QA] portlint: OK (looks fine.) testport: python 2.7 and 3.4 poudriere: i386, 9.3 (OK) poudriere: amd64, 9.3 (OK) poudriere: i386, 10.3 (OK) poudriere: amd64, 10.3 (OK) poudriere: i386, 11 (OK) poudriere: amd64, 11 (OK) poudriere: i386, 12 (OK) poudriere: amd64, 12 (OK)
Hi Danilo, I propose that the port is not built against python 2.7. python2.7 ncurses is broken with unicode (because we don't link against libncursesw. (see e.g. https://lists.freebsd.org/pipermail/freebsd-python/2012-August/004546.html ) rtv uses unicode which is misrendered with python2.7 which results in https://github.com/michael-lazar/rtv/issues/316
Hi Tilman. With python 2.7, 3.4 and 3.5 I can run rtv without crashes, but always using ascii mode: "UserWarning: System encoding was detected as (None) instead of UTF-8, falling back to ascii only mode warnings.warn(text)" From /tmp/rtv.log $ locale LANG= LC_CTYPE="C" LC_COLLATE="C" LC_TIME="C" LC_NUMERIC="C" LC_MONETARY="C" LC_MESSAGES="C" LC_ALL= That's why I am proposing this, but you have an important point that I didn't noticed. Using a locale, like this below, I got crashes on python 2.7, 3.4 and 3.5, like you reported on [1]. $ locale LANG=pt_BR.UTF-8 LC_CTYPE="pt_BR.UTF-8" LC_COLLATE="pt_BR.UTF-8" LC_TIME="pt_BR.UTF-8" LC_NUMERIC="pt_BR.UTF-8" LC_MONETARY="pt_BR.UTF-8" LC_MESSAGES="pt_BR.UTF-8" LC_ALL= Are you able to run rtv with unicode on python != 2.7 ? I will do more tests... Could you edit this issue putting needs-qa on keywords field ? Regards. [1] - https://github.com/michael-lazar/rtv/issues/316
Hi again. Based on this comment [1] I've used this patch[2], easy/fast/ugly approach, just for POC. # Python 2.7 - unicode - libncursesw /r/brasil http://dbaio.bs2cloud.com.br/FreeBSD/rtv/shots/rtv_python_cursesw/2016-11-02-184448_1366x768_scrot__unicode_py27.png /r/ru http://dbaio.bs2cloud.com.br/FreeBSD/rtv/shots/rtv_python_cursesw/2016-11-02-184501_1366x768_scrot__unicode_py27.png It works... but other problems could/will show up. I've tried another patch [3] as well, but python didn't linked with ncursesw. $ ldd /usr/local/lib/libreadline.so /usr/local/lib/libreadline.so: libncurses.so.8 => /lib/libncurses.so.8 (0x80124c000) libc.so.7 => /lib/libc.so.7 (0x800823000) ldd /usr/local/lib/libreadline.so /usr/local/lib/libreadline.so: libncurses.so.8 => /lib/libncurses.so.8 (0x80124c000) libncursesw.so.8 => /lib/libncursesw.so.8 (0x8014a0000) libc.so.7 => /lib/libc.so.7 (0x800823000) I think this is a problem of python/readline/ncurses. [1] - https://github.com/michael-lazar/rtv/issues/316#issuecomment-257666756 [2] - http://dbaio.bs2cloud.com.br/FreeBSD/rtv/shots/rtv_python_cursesw/python_curses.patch [3] - http://dbaio.bs2cloud.com.br/FreeBSD/rtv/shots/rtv_python_cursesw/readline-termcapw.patch For the record: # Python 2.7 - rtv ascii http://dbaio.bs2cloud.com.br/FreeBSD/rtv/shots/rtv_python27/2016-11-02-094715_1366x768_scrot__ascii.png http://dbaio.bs2cloud.com.br/FreeBSD/rtv/shots/rtv_python27/2016-11-02-094734_1366x768_scrot__ascii.png # Python 2.7 - rtv unicode http://dbaio.bs2cloud.com.br/FreeBSD/rtv/shots/rtv_python27/2016-11-02-190312_1366x768_scrot__unicode.png # Python 2.7 - rtv ascii http://dbaio.bs2cloud.com.br/FreeBSD/rtv/shots/rtv_python34/2016-11-02-100810_1366x768_scrot__ascii.png http://dbaio.bs2cloud.com.br/FreeBSD/rtv/shots/rtv_python34/2016-11-02-100827_1366x768_scrot__ascii.png # Python 3.4 - rtv unicode http://dbaio.bs2cloud.com.br/FreeBSD/rtv/shots/rtv_python34/2016-11-02-205235_1366x768_scrot__unicode.png http://dbaio.bs2cloud.com.br/FreeBSD/rtv/shots/rtv_python34/2016-11-02-205304_1366x768_scrot__unicode.png
A commit references this bug: Author: robak Date: Mon Nov 7 12:05:41 UTC 2016 New revision: 425610 URL: https://svnweb.freebsd.org/changeset/ports/425610 Log: www/rtv: update 1.9.1 -> 1.13.0 and new maintainer - Remove python version limit 3.3+ - Remove dependency www/py-tornado not used anymore - Add new dependencies: www/py-requests www/py-beautifulsoup devel/py-decorator devel/py-mailcap-fix devel/py-update_checker - Fix duplicate entry of dependency devel/py-six - Small change on pkg-descr (line with more than 80 characters) - Install manpage(1) properly - Set architecture neutral - Set MAINTAINER to submitter PR: 213149 Submitted by: Danilo G. Baio <dbaio@bsd.com.br> Changes: head/www/rtv/Makefile head/www/rtv/distinfo head/www/rtv/files/ head/www/rtv/files/patch-setup.py head/www/rtv/pkg-descr
Committed, thanks for taking care of this port!