Bug 213158 - net/guacamole-server: Default option change, new option
Summary: net/guacamole-server: Default option change, new option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL: https://guacamole.incubator.apache.or...
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2016-10-02 15:37 UTC by Ultima
Modified: 2016-10-03 15:54 UTC (History)
3 users (show)

See Also:

Attachments
guacamole-server.diff (1.38 KB, patch)
2016-10-02 15:37 UTC, Ultima 		Ultima1252: maintainer-approval+
Details | Diff
Revised patch making use of USE_GNOME (1.75 KB, patch)
2016-10-03 11:43 UTC, Thomas Zander 		Ultima1252: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ultima 2016-10-02 15:37:10 UTC 
Created attachment 175367 [details]
guacamole-server.diff

This is patch is to change the default options of guacamole-server. A new option WebP was also added in the last update, this is added default on.


* Default option change
* New option Webp
* Added ssl to USES

portlint -AC:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
0 fatal errors and 2 warnings found.


poudriere bulk -tC:
12amd64: success
12i386: success
11amd64: success
11i386: success
101amd64: Skipped: ca_root_nss-3.27 build failed
101i386: Skipped: ca_root_nss-3.27 build failed
93amd64: Skipped: ca_root_nss-3.27 build failed
93i386: Skipped: ca_root_nss-3.27 build failed
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2016-10-03 11:43:25 UTC 
Created attachment 175386 [details]
Revised patch making use of USE_GNOME

No significant functional change, but I would propose to use the USE_GNOME knobs when available.
Comment 2 Ultima 2016-10-03 14:01:07 UTC 
Comment on attachment 175386 [details]
Revised patch making use of USE_GNOME

This is perfect.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-10-03 15:51:20 UTC 
A commit references this bug:

Author: riggs
Date: Mon Oct  3 15:50:30 UTC 2016
New revision: 423202
URL: https://svnweb.freebsd.org/changeset/ports/423202

Log:
  New OPTIONs, general cleanup

  Detailed log
  - New option WEBP
  - Add WEBP to OPTIONS_DEFAULT
  - Added ssl to USES
  - USE_GNOME for dependencies on gnome components
  - Bump PORTREVISION

  PR:		213158
  Submitted by:	Ultima1252@gmail.com (maintainer)
  Reviewed by:	riggs
  Approved by:	Ultima1252@gmail.com (maintainer)

Changes:
  head/net/guacamole-server/Makefile