Created attachment 175532 [details] Svn patch that creates the ports 4 new ports that adds support for FastDFS devel/libfastcommon ftp/fastdfs ftp/php56-fastdfs ftp/php70-fastdfs - All 4 ports needs to be commited together becasue they depend on each other - All 4 ports passes poudriere testport - All 4 ports builds without a problem on fbsd 10.3 and 11, haven't tried others
Make Summary more informative. Note to submitter: these ports should really have a COMMENT= line after the MAINTAINER= line to be correct. Since they were missing, I used something that would likely be the COMMENT text for the Summary.
Created attachment 175560 [details] svn patch that creates the ports Adding comments as pointed out by Mark
Created attachment 175657 [details] svn patch that creates the ports
Created attachment 176012 [details] svn patch that creates the ports Changing a few things after pointers from gahr in #bsdports
Please make sure that portlint -AC is mostly clear. Thanks!
Created attachment 176019 [details] svn patch that creates the ports portlint -AC fixes
They now pass portlint -AC without warnings except a false positive because I'm using "make.sh install" so it triggeres on the install part
Created attachment 176020 [details] svn patch that creates the ports sorry, uploaded the old patch and not the new one
(In reply to Daniel Ylitalo from comment #7) Could be modified to use ${INSTALL_TARGET}.. I'll do that
Another thing, devel/libfastcommon doesn't respect PREFIX. I haven't checked the other ports. Please make sure that whatever is installed in /usr/local uses ${PREFIX} instead.
Created attachment 176095 [details] svn patch that creates the ports Changed hardcoded /usr/local to $(PREFIX)
Please install ports-mgmt/porttools and make sure to "port test" your ports. The PREFIX vs. LOCALBASE issue isn't solved yet (try building ftp/fastdfs with a prefix != /usr/local).
Sorry but I am not seeing what you are seeing, when running test port it does install to PREFIX=/tmp/libfastcommon-1.0.30/ as expected? This is unfortunately my first larger port, could you point out what I'm missing and I'll sort it out.
Sorry, I meant "try building ftp/fastdfs with a prefix != localbase". Basically, it's looking for dependencies in PREFIX (/tmp/fastdfs-5.0.8) instead of LOCALBASE (/usr/local): cc -Wall -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -g -O -DDEBUG_FLAG -c -o ../common/fdfs_global.o ../common/fdfs_global.c -I../common -I/tmp/fastdfs-5.0.8/include/fastcommon ../common/fdfs_global.c:20:10: fatal error: 'logger.h' file not found #include "logger.h" ^ 1 error generated. *** Error code 1 As you can see, -I/tmp/fastdfs-5.0.8/include/fastcommon should really be -I/usr/local/include/fastcommon
Aaaaah, so all compile includes should use LOCALBASE and all install paths should use PREFIX if I'm understanding you correctly?
That is correct :)
Created attachment 176185 [details] svn patch that creates the ports Change so that includes uses LOCALBASE instead of PREFIX
Alright, this is mostly fine, I have: - removed BUILD_DEPENDS where they were duplicate of LIB_DEPENDS - made sure that libfdfsclient.so has a soname I'm now building the ports in poudriere (10 and 11, i386 and amd64). I hope they build on 9... I don't have any(more) jails on that version.
A commit references this bug: Author: gahr Date: Thu Oct 27 05:49:12 UTC 2016 New revision: 424743 URL: https://svnweb.freebsd.org/changeset/ports/424743 Log: New ports: devel/libfastcommon, ftp/fastdfs, ftp/php(56|70)-fastdfs FastDFS is an open source high performance distributed file system (DFS). It's major functions include: file storing, file syncing and file accessing, and design for high capacity and load balance. WWW: https://github.com/happyfish100/fastdfs PR: 213311 Submitted by: Daniel Ylitalo <daniel@blodan.se> Changes: head/GIDs head/UIDs head/devel/Makefile head/devel/libfastcommon/ head/devel/libfastcommon/Makefile head/devel/libfastcommon/distinfo head/devel/libfastcommon/files/ head/devel/libfastcommon/files/patch-make.sh head/devel/libfastcommon/files/patch-src_Makefile.in head/devel/libfastcommon/pkg-descr head/devel/libfastcommon/pkg-plist head/ftp/Makefile head/ftp/fastdfs/ head/ftp/fastdfs/Makefile head/ftp/fastdfs/distinfo head/ftp/fastdfs/files/ head/ftp/fastdfs/files/fdfs_storaged.in head/ftp/fastdfs/files/fdfs_trackerd.in head/ftp/fastdfs/files/patch-client-Makefile.in head/ftp/fastdfs/files/patch-conf-client.conf head/ftp/fastdfs/files/patch-conf-storage.conf head/ftp/fastdfs/files/patch-conf-tracker.conf head/ftp/fastdfs/files/patch-make.sh head/ftp/fastdfs/files/patch-storage-Makefile.in head/ftp/fastdfs/files/patch-tracker-Makefile.in head/ftp/fastdfs/pkg-descr head/ftp/fastdfs/pkg-plist head/ftp/php56-fastdfs/ head/ftp/php56-fastdfs/Makefile head/ftp/php56-fastdfs/distinfo head/ftp/php56-fastdfs/files/ head/ftp/php56-fastdfs/files/patch-config.m4 head/ftp/php56-fastdfs/pkg-descr head/ftp/php56-fastdfs/pkg-message head/ftp/php70-fastdfs/ head/ftp/php70-fastdfs/Makefile head/ftp/php70-fastdfs/distinfo head/ftp/php70-fastdfs/files/ head/ftp/php70-fastdfs/files/patch-config.m4 head/ftp/php70-fastdfs/pkg-descr head/ftp/php70-fastdfs/pkg-message
Thanks for all the help!