Bug 213517 - audio/raop_play: Fix build with libc++ 3.9.0
Summary: audio/raop_play: Fix build with libc++ 3.9.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords: easy, patch
Depends on:
Blocks: 212343
  Show dependency tree / graph
 
Reported: 2016-10-15 22:52 UTC by Dimitry Andric
Modified: 2016-10-22 13:39 UTC (History)
1 user (show)

See Also:
riggs: merge-quarterly+

Attachments
Use correct type for strstr() return value (905 bytes, patch)
2016-10-15 22:52 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2016-10-15 22:52:27 UTC 
Created attachment 175799 [details]
Use correct type for strstr() return value

During the exp-run for bug 212343, audio/raop_play failed to build, because strstr() on a const string now returns a const string too:

aexcl_play.cxx:209:11: error: assigning to 'char *' from incompatible type 'const char *'
        if(!(astr=strstr(rargv[1],IP_NAME_DELIM))) return -1;
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This can easily be fixed by making astr a const char *.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-10-22 13:32:54 UTC 
A commit references this bug:

Author: riggs
Date: Sat Oct 22 13:32:11 UTC 2016
New revision: 424472
URL: https://svnweb.freebsd.org/changeset/ports/424472

Log:
  Fix build with libc++ 3.9.0

  PR:		213517
  Submitted by:	dim
  MFH:		2016Q4 (ports-secteam build fix blanket)

Changes:
  head/audio/raop_play/files/patch-aexcl_aexcl__play.cxx
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-10-22 13:37:55 UTC 
A commit references this bug:

Author: riggs
Date: Sat Oct 22 13:37:08 UTC 2016
New revision: 424473
URL: https://svnweb.freebsd.org/changeset/ports/424473

Log:
  MFH: r424472

  Fix build with libc++ 3.9.0

  PR:		213517
  Submitted by:	dim

  Approved by:	ports-secteam (build fix blanket)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/audio/raop_play/files/patch-aexcl_aexcl__play.cxx