Created attachment 175999 [details] Add bug fix patches to Makefile and distinfo The Lua team maintains a list of bugs found in each release of Lua since 4.0 [1] with examples that show the bug and a patch when the fix is available. This patch adds all three bug fixes available so far to the port Makefile and distinfo. A fourth bug fix should be available soon to fix a recently-found bug in coroutines -- I will submit another PR as soon as it is out. To make it easier for me to track the changes for each patch, I created a GitHub repository [2] with the Lua distribution and patches so I can reference them by commit id. As this port has no maintainer, I'd like to take the maintainership. (I'm also in the NetBSD Lua team.) [1] https://www.lua.org/bugs.html [2] https://github.com/salazar/lua
@Guilherme Should these bug fixes be merged to the quarterly branch for those users? Additionally, the version of the port needs to be modified/incremented in some manner. While we could 'just' increment PORTREVISION, it's probably worth using DISTVERSION to append some .X, -X, -pX or similar suffix. Is there an official version format in use upstream for these we can use? I note the URL's for each of bug 1-4 link to "5.3.3-4". Could we use a plain "5.3.3.4" ? Please also confirm that the changes pass QA (portlint, poudriere) if possible. For more details see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html And thank you for offering to maintain this port.
(In reply to Kubilay Kocak from comment #1) > @Guilherme Should these bug fixes be merged to the quarterly branch for those users? As this is bugfix-only, that'd be good. > Additionally, the version of the port needs to be modified/incremented in some manner. > While we could 'just' increment PORTREVISION, it's probably worth using DISTVERSION to > append some .X, -X, -pX or similar suffix. > Is there an official version format in use upstream for these we can use? I note the URL's > for each of bug 1-4 link to "5.3.3-4". Could we use a plain "5.3.3.4" ? There really isn't until they make for a new release; releases are numbered x.y.z, where x.y is the version and .z the release, where releases for the same x.y version are bug fixes. For this reason, I'm not sure it's a good idea to append a suffix apart from what PORTREVISION already appends (_x, right?). > Please also confirm that the changes pass QA (portlint, poudriere) if possible. For more > details see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html Just ran portlint and it looks fine.
Created attachment 176016 [details] Add bug fix patches to Makefile and distinfo; add my email to MAINTAINER Patch that adds my email to "MAINTAINER" -- cumulative to the bug fix patch.
Thank you Guilherme. Please update the attachment to include a PORTREVISION bump then (so that packages can be rebuilt). You may also set the maintainer-approval flag (on the attachment when submitting it) to +, with comment "Port is unmaintained, implicit approval".
(In reply to Kubilay Kocak from comment #4) > Please update the attachment to include a PORTREVISION bump then > (so that packages can be rebuilt). Should I add it as "1" or to the number of fixes, "3" -- it's currently omitted?
Created attachment 176017 [details] Add bug fix patches to Makefile and distinfo; bump PORTREVISION; add my email to MAINTAINER Port is unmaintained, implicit approval
What can we do to get this merged? Is there anything else I can help with?
(In reply to Guilherme Salazar from comment #7) @Guilherme I'm happy to take care of it this time, but for future issues confirmation of successful QA (including poudriere, not just portlint) is extremely well regarded. See bottom of comment 1 for link to poudriere instructions.
A commit references this bug: Author: koobs Date: Tue Oct 25 12:48:43 UTC 2016 New revision: 424620 URL: https://svnweb.freebsd.org/changeset/ports/424620 Log: lang/lua53: Add new MAINTAINER, Add bug fix patches The Lua team maintains a list of bugs found in each release of Lua since 4.0 [1] with examples that show the bug and a patch when the fix is available. This patch adds all three bug fixes available so far. A fourth bug fix should be made available soon to fix a recently-found bug in coroutines. To make it easier to track changes for each patch, a GitHub repository [2] has been created with the Lua distribution and patches so they can be referenced by commit id. - Pass MAINTAINER'ship to Submitter, who is also a member of the NetBSD Lua team. (Thanks!) [1] https://www.lua.org/bugs.html [2] https://github.com/salazar/lua PR: 213658 Submitted by: Guilherme Salazar <gmesalazar gmail com> MFH: 2014Q4 Changes: head/lang/lua53/Makefile head/lang/lua53/distinfo
A commit references this bug: Author: koobs Date: Tue Oct 25 13:06:55 UTC 2016 New revision: 424622 URL: https://svnweb.freebsd.org/changeset/ports/424622 Log: MFH: r424620 lang/lua53: Add new MAINTAINER, Add bug fix patches The Lua team maintains a list of bugs found in each release of Lua since 4.0 [1] with examples that show the bug and a patch when the fix is available. This patch adds all three bug fixes available so far. A fourth bug fix should be made available soon to fix a recently-found bug in coroutines. To make it easier to track changes for each patch, a GitHub repository [2] has been created with the Lua distribution and patches so they can be referenced by commit id. - Pass MAINTAINER'ship to Submitter, who is also a member of the NetBSD Lua team. (Thanks!) [1] https://www.lua.org/bugs.html [2] https://github.com/salazar/lua PR: 213658 Submitted by: Guilherme Salazar <gmesalazar gmail com> Approved by: ports-secteam (blanket) Changes: _U branches/2016Q4/ branches/2016Q4/lang/lua53/Makefile branches/2016Q4/lang/lua53/distinfo
Committed and merged (to quarterly branch) with minor commit log message edits. Thank you Guilherme!
(In reply to Kubilay Kocak from comment #8) Thanks for clearing up; I thought that was an or :) next time I will run poudriere as well
(In reply to Guilherme Salazar from comment #12) You'll like poudriere, might be interesting to see if it could be used for netbsd's "ports" ?
(In reply to Kubilay Kocak from comment #13) I will look into it; I'm not aware of a poudriere-like tool used in pkgsrc.