Created attachment 176260 [details] Proposed patch (since 422087 revision) Patch to update games/pioneer port from 20160610 to 20161028 version. Look following link for changes: https://github.com/pioneerspacesim/pioneer/compare/20160610...20161028 - Add BUILD_VERSION variable, which allows to use GH_TAGNAME for git commit - Move QUICKSTART_PATH variable to DOCS_SUB_LIST option - Add NOGPUJOBS option - Remove bsd.port.options.mk include - Clarify sed patch for libprofiler.a - Add new file to sed patch for FreeBSD 9.3
(In reply to lightside from comment #0) > Created attachment 176260 [details] > Proposed patch (since 422087 revision) > > Patch to update games/pioneer port from 20160610 to 20161028 version. > > Look following link for changes: > https://github.com/pioneerspacesim/pioneer/compare/20160610...20161028 > > - Add BUILD_VERSION variable, which allows to use GH_TAGNAME for git commit I'm not getting the reason of this patch. At present BUILD_VERSION and GH_TAGNAME would be the same. Without this change you're using GH_TAGNAME in PORTVERSION, which is not a problem. If naming schema of the port changges, you'll anyway have to change PORTVERSION, and most probably have fixed PORTVERSION and GH_TAGNAME depending on PORTVERSION (which is the default). So I'm not getting what you are gaining by adding a variable which will be the same as GH_TAGNAME anyway.
Created attachment 176350 [details] Proposed patch (since 422087 revision) (In reply to comment #1) > So I'm not getting what you are gaining by adding a variable which will be the > same as GH_TAGNAME anyway. I used this variant for git bisection (related to NOGPUJOBS port's option). (In reply to comment #0) > - Add BUILD_VERSION variable, which allows to use GH_TAGNAME for git commit Ok, I removed this.
A commit references this bug: Author: madpilot Date: Wed Nov 2 10:24:08 UTC 2016 New revision: 425132 URL: https://svnweb.freebsd.org/changeset/ports/425132 Log: - Update pioneer to 20161028 - Add NOGPUJOBS option PR: 213873 Submitted by: lightside <lightside@gmx.com> Changes: head/games/pioneer/Makefile head/games/pioneer/distinfo
Committed. Thanks!