Bug 213929 - net-im/openfire: Update to 4.0.3
Summary: net-im/openfire: Update to 4.0.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pietro Cerutti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-31 01:05 UTC by Danilo G. Baio
Modified: 2016-11-03 12:02 UTC (History)
0 users

See Also:
gahr: maintainer-feedback+

Attachments
openfire-4.0.3.patch (2.82 KB, patch)
2016-10-31 01:05 UTC, Danilo G. Baio 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Danilo G. Baio freebsd_committer freebsd_triage 2016-10-31 01:05:18 UTC 
Created attachment 176324 [details]
openfire-4.0.3.patch

- Update to 4.0.3
- Switch to options helpers
- STRIP libshaj.so

Changelog: http://download.igniterealtime.org/openfire/docs/latest/changelog.html

[Q/A]

testport: 
	poudriere: i386,  9.3   (not tested, still building all dependencies)
	poudriere: amd64, 9.3   (OK)
	poudriere: i386,  10.3  (OK)
	poudriere: amd64, 10.3  (OK)
	poudriere: i386,  11    (waiting)
	poudriere: amd64, 11    (waiting)
	poudriere: i386,  12    (waiting)
	poudriere: amd64, 12    (OK)

Same warnings on portlint:
WARN: Makefile: possible use of absolute pathname "/var/log/openfire".
WARN: Makefile: possible use of absolute pathname "/var/db/openfire".
FATAL: Makefile: you should use ${JAVALIBDIR} in BUILD_DEPENDS/RUN_DEPENDS to define dependencies on JAR files installed in ${JAVAJARDIR}
1 fatal error and 2 warnings found.

====> Running Q/A tests (stage-qa)
Warning: Bad symlink '/usr/local/share/java/openfire/conf' pointing to an absolute pathname '/usr/local/etc/openfire'
Warning: Bad symlink '/usr/local/share/java/openfire/resources/security' pointing to an absolute pathname '/usr/local/etc/openfire'
Warning: Bad symlink '/usr/local/share/java/openfire/embedded-db' pointing to an absolute pathname '/var/db/openfire'
Warning: Bad symlink '/usr/local/share/java/openfire/logs' pointing to an absolute pathname '/var/log/openfire'
Comment 1 Pietro Cerutti freebsd_committer freebsd_triage 2016-10-31 10:42:14 UTC 
Two minor things, then approved:

- no tab after the equal sign in OPTIONS_DEFAULT=PLUGINS - just leave it as it was
- please also fix the s/JAVAJARDIR/JAVALIBDIR/ warning in RUN_DEPENDS

Thanks!
Comment 2 Pietro Cerutti freebsd_committer freebsd_triage 2016-10-31 15:03:05 UTC 
Oh, nevermind, I didn't notice you don't have a commit bit. I'll take care of committing this.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-10-31 15:19:12 UTC 
A commit references this bug:

Author: gahr
Date: Mon Oct 31 15:18:59 UTC 2016
New revision: 425007
URL: https://svnweb.freebsd.org/changeset/ports/425007

Log:
  net-im/openfire: update to 4.0.3, switch to OPTIONS helpers

  https://download.igniterealtime.org/openfire/docs/4.0.3/changelog.html

  PR:		213929
  Submitted by:	Danilo G. Baio <dbaio@bsd.com.br>

Changes:
  head/net-im/openfire/Makefile
  head/net-im/openfire/distinfo
Comment 4 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-31 15:57:35 UTC 
Thanks for your time and feedback! 

This change will fix portlint.

-RUN_DEPENDS=   ${JAVALIBDIR}/slf4j-api.jar:devel/slf4j
+RUN_DEPENDS=   slf4j>=1.7.7:devel/slf4j

This version is based on work/openfire_src/build/lib/versions.txt file.

Regards.
Comment 5 Danilo G. Baio freebsd_committer freebsd_triage 2016-10-31 22:14:00 UTC 
For the record, all builds were finished.

testport: 
	poudriere: i386,  9.3   (OK)
	poudriere: amd64, 9.3   (OK)
	poudriere: i386,  10.3  (OK)
	poudriere: amd64, 10.3  (OK)
	poudriere: i386,  11    (OK)
	poudriere: amd64, 11    (OK)
	poudriere: i386,  12    (OK)
	poudriere: amd64, 12    (OK)

Only the portlint error remains. The fix on comment 4 will fix that.

Regards.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-11-03 12:02:22 UTC 
A commit references this bug:

Author: gahr
Date: Thu Nov  3 12:02:15 UTC 2016
New revision: 425203
URL: https://svnweb.freebsd.org/changeset/ports/425203

Log:
  net-im/openfire: better RUN_DEPENDS line (no actual change in dependencies)

  PR:		213929
  Submitted by:	Danilo G. Baio <dbaio@bsd.com.br>

Changes:
  head/net-im/openfire/Makefile