Created attachment 176326 [details] shar archive Passes poudriere on 11amd64 and 10i386.
Created attachment 176329 [details] shar archive Corrected the license.
Created attachment 176359 [details] shar archive Minor changes.
Comment on attachment 176359 [details] shar archive > XLICENSE_FILE= ${WRKDIR}/EmptyEpsilon-${DISTVERSIONFULL}/LICENSE ^^^^^^^^^^^^ Why not ${WRKSRC}/LICENSE ? Otherwise, maybe substitute one more word e.g., -LICENSE_FILE= ${WRKDIR}/EmptyEpsilon-${DISTVERSIONFULL}/LICENSE +LICENSE_FILE= ${WRKDIR}/${GH_PROJECT}-${DISTVERSIONFULL}/LICENSE > XLIB_DEPENDS= libsfml-system.so:devel/sfml Fixed in ports r425104, so EmptyEpsilon builds fine on 9.x. ;) > XCMAKE_ARGS= -DSERIOUS_PROTON_DIR=../SeriousProton-${DISTVERSIONFULL}/ To make it less fragile maybe use WRKSRC_<group> e.g., -CMAKE_ARGS= -DSERIOUS_PROTON_DIR=../SeriousProton-${DISTVERSIONFULL}/ +CMAKE_ARGS= -DSERIOUS_PROTON_DIR="${WRKSRC_sproton}/" > XPATCH_WRKSRC= ${WRKDIR} Why? Only post-patch below touches the files outside of WRKSRC. > Xpost-patch: > X @${REINPLACE_CMD} -e 's|basepath + |"${PREFIX}/share/emptyepsilon/" + basepath + |' \ > X ${WRKDIR}/SeriousProton-*/src/resources.cpp > X @${REINPLACE_CMD} -e 's|loadFromFile("resources/"|loadFromFile("${PREFIX}/share/emptyepsilon/resources/"|' \ > X ${WRKDIR}/SeriousProton-*/src/postProcessManager.cpp Can you keep letter case consistent: bin/EmptyEpsilon vs. share/emptyepsilon vs. ~/.emptyepsilon ? If you pick lower case rename the port to match it e.g., -PORTNAME= EmptyEpsilon +PORTNAME= emptyepsilon ... -GH_ACCOUNT= daid +GH_TUPLE+= daid:EmptyEpsilon:${DISTVERSIONFULL} > sed 's/^X//' >games/EmptyEpsilon/pkg-descr << '930a933c75becaad7502e40f41a5a7c0' > XEmptyEpsilon is a spaceship bridge simulator game. The first line in pkg-descr can be dropped as it matches ${COMMENT} in Makefile and is obvious from reading the rest.
(In reply to Jan Beich (mail not working) from comment #3) >> XPATCH_WRKSRC= ${WRKDIR} > >Why? Only post-patch below touches the files outside of WRKSRC. I guess you want to prepare for patches in the future. Better move WRKSRC_sproton under WRKSRC then e.g., -GH_TUPLE+= daid:SeriousProton:${DISTVERSIONFULL}:sproton +GH_TUPLE+= daid:SeriousProton:${DISTVERSIONFULL}:sproton/SeriousProton ... -CMAKE_ARGS= -DSERIOUS_PROTON_DIR=../SeriousProton-${DISTVERSIONFULL}/ +CMAKE_ARGS= -DSERIOUS_PROTON_DIR="SeriousProton/"
Created attachment 176405 [details] shar I edited the port too many times, there used to be patches to SeriousProton, but not any more. Thanks for pointing these out, I fixed them.
A commit references this bug: Author: jbeich Date: Wed Nov 2 06:25:40 UTC 2016 New revision: 425114 URL: https://svnweb.freebsd.org/changeset/ports/425114 Log: games/emptyepsilon: add new port PR: 213939 Submitted by: yuri@rawbw.com EmptyEpsilon places you in the roles of a spaceship's bridge officers, like those seen in Star Trek. While you can play EmptyEpsilon alone or with friends, the best experience involves 6 players working together on each ship. Each officer fills a unique role: Captain, Helms, Weapons, Relay, Science, and Engineering. Except for the Captain, each officer operates part of the ship through a specialized screen. The Captain relies on their trusty crew to report information and follow orders. http://emptyepsilon.org/ Changes: head/games/Makefile head/games/emptyepsilon/ head/games/emptyepsilon/Makefile head/games/emptyepsilon/distinfo head/games/emptyepsilon/files/ head/games/emptyepsilon/files/patch-CMakeLists.txt head/games/emptyepsilon/files/patch-src_packResourceProvider.cpp head/games/emptyepsilon/files/patch-src_screens_crew6_scienceScreen.cpp head/games/emptyepsilon/files/patch-src_screens_extra_databaseScreen.cpp head/games/emptyepsilon/pkg-descr head/games/emptyepsilon/pkg-plist
Thanks. Landed with minor changes to post-patch. Note, adjust "Your real name" in bugzilla if you want committers like me to reference you in logs via "Submitted by" by name (i.e. not just email). https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=account Consider writing DESKTOP_ENTRIES for games or apps with GUI that lack .desktop file in future. If you're unsure how Icon field works see bug 197444 discussion. https://www.freebsd.org/doc/en/books/porters-handbook/using-x11.html#desktop-entries
Thanks! I updated the name field. And I notified the upstream to add .desktop and icons, so that the next release will likely have them. Yuri